GNOME Bugzilla – Bug 81479
"Repeat Last" incorrectly enabled if Lighting Effects plug-in is cancelled
Last modified: 2004-03-16 01:13:26 UTC
To reproduce: - Select the "Lighting Effects" filter - Press Cancel - Now the 'Repeat Last' menuentry isn't grayed out anymore, which I think is incorrect since we haven't really done anything yet. - Select any other filter, for example Blur - Press Cancel again - Select 'Repeat Last' - Now GIMP exectures the last selected (but canceled!) filter, in this case Blur.
*** Bug 81480 has been marked as a duplicate of this bug. ***
This looks like a combination of two problems: - The Lighting Effects plug-in does not respond correctly to Cancel and reports a success when it shouldn't (I haven't checked the code yet, but this is probably what happens). This is a bug in the plug-in, which results in the "Repeat Last" and "Re-Show Last" options to become active when they shouldn't. - Independently of this, the GIMP does not behave correctly when "Repeat Last" is used after something was cancelled. This is a user interface problem that deserves a separate bug report. I have just reported this in bug #81636. I propose that we keep the focus of this bug report on the first part of the problem (the Lighting Effect plug-in). The other part will be solved in bug #81636. I have changed the summary of this bug report accordingly.
ChangeLog: 2002-12-23 Maurits Rijk <lpeek.mrijk@consunet.nl> * plug-ins/Lighting/lighting_main.c (run): fixed #81479 ("Repeat Last" incorrectly enabled if Lighting Effects plug-in is cancelled)
For the record, this was fixed in CVS HEAD but not in the 1.2 branch.
Fixed again in, this time in the core: 2004-03-16 Simon Budig <simon@gimp.org> * app/gui/plug-in-commands.c: Update the Plugin Menu immediately after setting the last invoked plugin. Fixes inconsistencies between name shown and plugin invoked. Fixes #136909, #137242 and #81479 (again, the fix in lightening_main.c only probably was bogus, since this must not rely on correctly written plugins).