After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 797371 - codecparsers_h26x: Should return NO_NAL_END on 5/6 bytes NALs
codecparsers_h26x: Should return NO_NAL_END on 5/6 bytes NALs
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-11-02 16:29 UTC by Nicolas Dufresne (ndufresne)
Modified: 2018-11-03 14:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
h264parser: Stop considering 5 bytes NAL complete (1.35 KB, patch)
2018-11-02 18:28 UTC, Nicolas Dufresne (ndufresne)
none Details | Review
h265parse: Add unit test parsing 5 valid bytes of a NAL (1.52 KB, patch)
2018-11-02 18:28 UTC, Nicolas Dufresne (ndufresne)
none Details | Review
h264parser: Add unit test parsing 5 valid bytes of a NAL (1.52 KB, patch)
2018-11-02 18:29 UTC, Nicolas Dufresne (ndufresne)
none Details | Review
h264parser: Stop considering 5 bytes NAL complete (1.35 KB, patch)
2018-11-02 19:56 UTC, Nicolas Dufresne (ndufresne)
none Details | Review
h264parser: Add unit test parsing 5 valid bytes of a NAL (1.88 KB, patch)
2018-11-02 19:56 UTC, Nicolas Dufresne (ndufresne)
none Details | Review
h265parser: Add same parsing test as for H264 (3.77 KB, patch)
2018-11-02 19:56 UTC, Nicolas Dufresne (ndufresne)
none Details | Review
h265parser: Stop considering 6 bytes NAL complete (1.32 KB, patch)
2018-11-02 19:57 UTC, Nicolas Dufresne (ndufresne)
none Details | Review

Description Nicolas Dufresne (ndufresne) 2018-11-02 16:29:52 UTC
-- regression introduce by https://bugzilla.gnome.org/show_bug.cgi?id=732553 ---

If you pass any valid 5 first bytes of a NAL to the parser, it will now always return OK instead of NO_NAL_END. This is caused by broken code trying to handle single byte SEQ_END / STREAM_END as being complete NAL.
Comment 1 Nicolas Dufresne (ndufresne) 2018-11-02 18:28:20 UTC
Created attachment 374135 [details] [review]
h264parser: Stop considering 5 bytes NAL complete

This is only TRUE for SEQ_END / STREAM_END. Before this patch, passing
any valid 5 bytes of a NAL would make the parser pretend this NAL is
complete.
Comment 2 Nicolas Dufresne (ndufresne) 2018-11-02 18:28:27 UTC
Created attachment 374136 [details] [review]
h265parse: Add unit test parsing 5 valid bytes of a NAL

In the case 5 valid bytes of a slice NAL, the parser should return
NO_NAL_END.
Comment 3 Nicolas Dufresne (ndufresne) 2018-11-02 18:29:07 UTC
Created attachment 374137 [details] [review]
h264parser: Add unit test parsing 5 valid bytes of a NAL

In the case 5 valid bytes of a slice NAL, the parser should return
NO_NAL_END.
Comment 4 Nicolas Dufresne (ndufresne) 2018-11-02 19:07:30 UTC
Found that same issue exist in HEVC parser.
Comment 5 Nicolas Dufresne (ndufresne) 2018-11-02 19:56:50 UTC
Created attachment 374138 [details] [review]
h264parser: Stop considering 5 bytes NAL complete

This is only TRUE for SEQ_END / STREAM_END. Before this patch, passing
any valid 5 bytes of a NAL would make the parser pretend this NAL is
complete.
Comment 6 Nicolas Dufresne (ndufresne) 2018-11-02 19:56:53 UTC
Created attachment 374139 [details] [review]
h264parser: Add unit test parsing 5 valid bytes of a NAL

In the case 5 valid bytes of a slice NAL, the parser should return
NO_NAL_END.
Comment 7 Nicolas Dufresne (ndufresne) 2018-11-02 19:56:57 UTC
Created attachment 374140 [details] [review]
h265parser: Add same parsing test as for H264

This adds the same test as found in H264 test.
Comment 8 Nicolas Dufresne (ndufresne) 2018-11-02 19:57:01 UTC
Created attachment 374141 [details] [review]
h265parser: Stop considering 6 bytes NAL complete

This is only TRUE for EOS / EOB NALs. Before this patch, passing
any valid 6 bytes of a NAL would make the parser pretend this NAL is
complete.
Comment 9 GStreamer system administrator 2018-11-03 14:37:29 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/812.