GNOME Bugzilla – Bug 797371
codecparsers_h26x: Should return NO_NAL_END on 5/6 bytes NALs
Last modified: 2018-11-03 14:37:29 UTC
-- regression introduce by https://bugzilla.gnome.org/show_bug.cgi?id=732553 --- If you pass any valid 5 first bytes of a NAL to the parser, it will now always return OK instead of NO_NAL_END. This is caused by broken code trying to handle single byte SEQ_END / STREAM_END as being complete NAL.
Created attachment 374135 [details] [review] h264parser: Stop considering 5 bytes NAL complete This is only TRUE for SEQ_END / STREAM_END. Before this patch, passing any valid 5 bytes of a NAL would make the parser pretend this NAL is complete.
Created attachment 374136 [details] [review] h265parse: Add unit test parsing 5 valid bytes of a NAL In the case 5 valid bytes of a slice NAL, the parser should return NO_NAL_END.
Created attachment 374137 [details] [review] h264parser: Add unit test parsing 5 valid bytes of a NAL In the case 5 valid bytes of a slice NAL, the parser should return NO_NAL_END.
Found that same issue exist in HEVC parser.
Created attachment 374138 [details] [review] h264parser: Stop considering 5 bytes NAL complete This is only TRUE for SEQ_END / STREAM_END. Before this patch, passing any valid 5 bytes of a NAL would make the parser pretend this NAL is complete.
Created attachment 374139 [details] [review] h264parser: Add unit test parsing 5 valid bytes of a NAL In the case 5 valid bytes of a slice NAL, the parser should return NO_NAL_END.
Created attachment 374140 [details] [review] h265parser: Add same parsing test as for H264 This adds the same test as found in H264 test.
Created attachment 374141 [details] [review] h265parser: Stop considering 6 bytes NAL complete This is only TRUE for EOS / EOB NALs. Before this patch, passing any valid 6 bytes of a NAL would make the parser pretend this NAL is complete.
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/812.