After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 797363 - video-anc: Add unit tests and fix invalid reads in VBI parser
video-anc: Add unit tests and fix invalid reads in VBI parser
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other All
: Normal normal
: 1.15.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-11-01 17:22 UTC by Sebastian Dröge (slomo)
Modified: 2018-11-01 17:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
video-anc: Fix bounds checks when parsing VBI data (2.35 KB, patch)
2018-11-01 17:22 UTC, Sebastian Dröge (slomo) 		committed Details | Review
video-anc: Add unit tests for VBI parsing (10.48 KB, patch)
2018-11-01 17:22 UTC, Sebastian Dröge (slomo) 		committed Details | Review
decklinkvideosrc: Add support for extracing CEA608 according to S334-1 Annex A (2.74 KB, patch)
2018-11-01 17:22 UTC, Sebastian Dröge (slomo) 		committed Details | Review

Description Sebastian Dröge (slomo) 2018-11-01 17:22:00 UTC 
See commit messages for details
Comment 1 Sebastian Dröge (slomo) 2018-11-01 17:22:15 UTC 
Created attachment 374127 [details] [review]
video-anc: Fix bounds checks when parsing VBI data

We were reading more bytes than we allocated.
Comment 2 Sebastian Dröge (slomo) 2018-11-01 17:22:24 UTC 
Created attachment 374128 [details] [review]
video-anc: Add unit tests for VBI parsing
Comment 3 Sebastian Dröge (slomo) 2018-11-01 17:22:47 UTC 
Created attachment 374129 [details] [review]
decklinkvideosrc: Add support for extracing CEA608 according to S334-1 Annex A
Comment 4 Sebastian Dröge (slomo) 2018-11-01 17:31:35 UTC 
Attachment 374127 [details] pushed as 4666444 - video-anc: Fix bounds checks when parsing VBI data
Attachment 374128 [details] pushed as a1c1495 - video-anc: Add unit tests for VBI parsing
Comment 5 Sebastian Dröge (slomo) 2018-11-01 17:32:21 UTC 
Attachment 374129 [details] pushed as 3d8a0b8 - decklinkvideosrc: Add support for extracing CEA608 according to S334-1 Annex A