After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 797361 - Should include ONVIF headers in rtsp-server.h
Should include ONVIF headers in rtsp-server.h
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-rtsp-server
unspecified
Other Linux
: Normal normal
: 1.15.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-10-31 16:17 UTC by Sebastian Dröge (slomo)
Modified: 2018-11-01 08:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Include ONVIF types from single-include rtsp-server.h (20.23 KB, patch)
2018-11-01 08:19 UTC, Sebastian Dröge (slomo)
committed Details | Review

Description Sebastian Dröge (slomo) 2018-10-31 16:17:30 UTC
Unfortunately just adding them fails the build due to circular includes.

rtsp-server.h should be a single-include header instead of being a mix between the GstRTSPServer type related things and a single-include header.

How would we call the header related to the GstRTSPServer type?
Comment 1 Sebastian Dröge (slomo) 2018-11-01 08:19:53 UTC
Created attachment 374118 [details] [review]
Include ONVIF types from single-include rtsp-server.h

... by actually making it a single-include header and moving everything
related to the GstRTSPServer type to rtsp-server-object.h instead.
Otherwise there are too many circular includes.
Comment 2 Sebastian Dröge (slomo) 2018-11-01 08:20:23 UTC
Attachment 374118 [details] pushed as 84a7f45 - Include ONVIF types from single-include rtsp-server.h