After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 797359 - video format of endianness declared in vaapi need to be modified.
video format of endianness declared in vaapi need to be modified.
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gstreamer-vaapi
unspecified
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-10-31 05:51 UTC by He Junyan
Modified: 2018-11-03 15:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
THe patch (4.32 KB, patch)
2018-10-31 05:55 UTC, He Junyan 		none Details | Review

Description He Junyan 2018-10-31 05:51:29 UTC 
The code:

#elif G_BYTE_ORDER == G_LITTLE_ENDIAN
  DEF_RGB (BGRA, ('B', 'G', 'R', 'A'), LSB, 32,
       32, 0x00ff0000, 0x0000ff00, 0x000000ff, 0xff000000),
  DEF_RGB (RGBA, ('R', 'G', 'B', 'A'), LSB, 32,
       32, 0x000000ff, 0x0000ff00, 0x00ff0000, 0xff000000),
  DEF_RGB (BGRx, ('B', 'G', 'R', 'X'), LSB, 32,
       24, 0x00ff0000, 0x0000ff00, 0x000000ff, 0x00000000),
  DEF_RGB (RGBx, ('R', 'G', 'B', 'X'), LSB, 32,
       24, 0x000000ff, 0x0000ff00, 0x00ff0000, 0x00000000),
-#endif

Make the ARGB xRGB kind video format not suppored when on little endian machine like X86

The video format should not directly relate to endianness. For example,
ARGB on big endian should not be simplely seen as BGRA on little endian machine.
We should provide endianess convert or format convert help functions if endianness does not match.
Comment 1 He Junyan 2018-10-31 05:55:08 UTC 
Created attachment 374114 [details] [review]
THe patch
Comment 2 Víctor Manuel Jáquez Leal 2018-10-31 19:02:32 UTC 
Hi,

Thanks for the patch.

Can you explain me what the use case if failing to you?
Comment 3 He Junyan 2018-11-01 07:46:45 UTC 
When we use command line:

gst-launch-1.0 videotestsrc ! videoparse width=320 height=240 format=argb ! vaapipostproc format=nv12 ! fakesink

It will cause

0:00:02.207389696 14486 0x55832b526230 DEBUG           vaapidisplay gstvaapidisplay.c:671:ensure_image_formats: 27 image formats
0:00:02.207407473 14486 0x55832b526230 DEBUG           vaapidisplay gstvaapidisplay.c:673:ensure_image_formats:   BGRA
0:00:02.207422660 14486 0x55832b526230 DEBUG           vaapidisplay gstvaapidisplay.c:673:ensure_image_formats:   ARGB
0:00:02.207438443 14486 0x55832b526230 DEBUG           vaapidisplay gstvaapidisplay.c:673:ensure_image_formats:   RGBA
0:00:02.207455803 14486 0x55832b526230 DEBUG           vaapidisplay gstvaapidisplay.c:673:ensure_image_formats:   ABGR
0:00:02.207469341 14486 0x55832b526230 DEBUG           vaapidisplay gstvaapidisplay.c:673:ensure_image_formats:   BGRX
0:00:02.207484450 14486 0x55832b526230 DEBUG           vaapidisplay gstvaapidisplay.c:673:ensure_image_formats:   XRGB
0:00:02.207501323 14486 0x55832b526230 DEBUG           vaapidisplay gstvaapidisplay.c:673:ensure_image_formats:   RGBX
0:00:02.207514956 14486 0x55832b526230 DEBUG           vaapidisplay gstvaapidisplay.c:673:ensure_image_formats:   XBGR
0:00:02.207530027 14486 0x55832b526230 DEBUG           vaapidisplay gstvaapidisplay.c:673:ensure_image_formats:   XBGR
0:00:02.207547047 14486 0x55832b526230 DEBUG           vaapidisplay gstvaapidisplay.c:673:ensure_image_formats:   NV12
0:00:02.207560671 14486 0x55832b526230 DEBUG           vaapidisplay gstvaapidisplay.c:673:ensure_image_formats:   NV21
0:00:02.207575506 14486 0x55832b526230 DEBUG           vaapidisplay gstvaapidisplay.c:673:ensure_image_formats:   YUY2
0:00:02.207592358 14486 0x55832b526230 DEBUG           vaapidisplay gstvaapidisplay.c:673:ensure_image_formats:   UYVY
0:00:02.207606027 14486 0x55832b526230 DEBUG           vaapidisplay gstvaapidisplay.c:673:ensure_image_formats:   YV12
0:00:02.207622001 14486 0x55832b526230 DEBUG           vaapidisplay gstvaapidisplay.c:673:ensure_image_formats:   IYUV
0:00:02.207635708 14486 0x55832b526230 DEBUG           vaapidisplay gstvaapidisplay.c:673:ensure_image_formats:   422H
0:00:02.207651126 14486 0x55832b526230 DEBUG           vaapidisplay gstvaapidisplay.c:673:ensure_image_formats:   422V
0:00:02.207664616 14486 0x55832b526230 DEBUG           vaapidisplay gstvaapidisplay.c:673:ensure_image_formats:   Y800
0:00:02.207680108 14486 0x55832b526230 DEBUG           vaapidisplay gstvaapidisplay.c:673:ensure_image_formats:   411P
0:00:02.207693561 14486 0x55832b526230 DEBUG           vaapidisplay gstvaapidisplay.c:673:ensure_image_formats:   IMC3
0:00:02.207709181 14486 0x55832b526230 DEBUG           vaapidisplay gstvaapidisplay.c:673:ensure_image_formats:   444P
0:00:02.207726128 14486 0x55832b526230 DEBUG           vaapidisplay gstvaapidisplay.c:673:ensure_image_formats:   RGBP
0:00:02.207739753 14486 0x55832b526230 DEBUG           vaapidisplay gstvaapidisplay.c:673:ensure_image_formats:   BGRP
0:00:02.207755126 14486 0x55832b526230 DEBUG           vaapidisplay gstvaapidisplay.c:673:ensure_image_formats:   P208
0:00:02.207772128 14486 0x55832b526230 DEBUG           vaapidisplay gstvaapidisplay.c:673:ensure_image_formats:   P010
0:00:02.207785479 14486 0x55832b526230 DEBUG           vaapidisplay gstvaapidisplay.c:673:ensure_image_formats:   AYUV
0:00:02.207801791 14486 0x55832b526230 DEBUG           vaapidisplay gstvaapidisplay.c:673:ensure_image_formats:   Y410
0:00:02.207819440 14486 0x55832b526230 DEBUG           vaapidisplay gstvaapidisplay.c:199:append_formats: unsupported format ARGB
0:00:02.207834723 14486 0x55832b526230 DEBUG           vaapidisplay gstvaapidisplay.c:199:append_formats: unsupported format ABGR
0:00:02.207851431 14486 0x55832b526230 DEBUG           vaapidisplay gstvaapidisplay.c:199:append_formats: unsupported format XRGB
0:00:02.207866519 14486 0x55832b526230 DEBUG           vaapidisplay gstvaapidisplay.c:199:append_formats: unsupported format XBGR
0:00:02.207882500 14486 0x55832b526230 DEBUG           vaapidisplay gstvaapidisplay.c:199:append_formats: unsupported format XBGR
0:00:02.207899799 14486 0x55832b526230 DEBUG           vaapidisplay gstvaapidisplay.c:199:append_formats: unsupported format NV21
0:00:02.207915815 14486 0x55832b526230 DEBUG           vaapidisplay gstvaapidisplay.c:199:append_formats: unsupported format IYUV
0:00:02.207931079 14486 0x55832b526230 DEBUG           vaapidisplay gstvaapidisplay.c:199:append_formats: unsupported format 422H
0:00:02.207948698 14486 0x55832b526230 DEBUG           vaapidisplay gstvaapidisplay.c:199:append_formats: unsupported format 422V
0:00:02.207964825 14486 0x55832b526230 DEBUG           vaapidisplay gstvaapidisplay.c:199:append_formats: unsupported format 411P
0:00:02.207979586 14486 0x55832b526230 DEBUG           vaapidisplay gstvaapidisplay.c:199:append_formats: unsupported format IMC3
0:00:02.207994993 14486 0x55832b526230 DEBUG           vaapidisplay gstvaapidisplay.c:199:append_formats: unsupported format 444P
0:00:02.208011973 14486 0x55832b526230 DEBUG           vaapidisplay gstvaapidisplay.c:199:append_formats: unsupported format RGBP
0:00:02.208026171 14486 0x55832b526230 DEBUG           vaapidisplay gstvaapidisplay.c:199:append_formats: unsupported format BGRP
0:00:02.208041953 14486 0x55832b526230 DEBUG           vaapidisplay gstvaapidisplay.c:199:append_formats: unsupported format P208
0:00:02.208059440 14486 0x55832b526230 DEBUG           vaapidisplay gstvaapidisplay.c:199:append_formats: unsupported format Y410


VA report we support ARGB for example but we failed to recognize it in gst-vaapi. This causes the input buffer pool failed to create and the pipeline can't run.
Comment 4 GStreamer system administrator 2018-11-03 15:56:33 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/issues/112.