After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 797354 - meson: Unkonw variables while disabling msdk plugin
meson: Unkonw variables while disabling msdk plugin
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-10-29 21:40 UTC by Jordan Petridis
Modified: 2018-11-03 14:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
meson: declare variables (1.07 KB, patch)
2018-10-29 21:41 UTC, Jordan Petridis
none Details | Review

Description Jordan Petridis 2018-10-29 21:40:03 UTC
While building with auto_features=enabled -Dmsdk=disabled I encountered the following error.

'tests/check/meson.build:18:0: ERROR:  Unknown variable "have_msdk".'


same error was also thrown later for "msdk_dep". 


This happened right after 55134df54c99b09556d3d0f60b9b4f029123af0e which to my understanding added an early exit before the variables where declared.

I am not sure if the following patch is the proper way to fix it, using auto-feature magic in the test too would probably be cleaner but I did not managed to figure out if its possible.

Tested the following patch in gnome-build-meta. https://gitlab.gnome.org/GNOME/gnome-build-meta/commit/8915cb51a25559163e2f1e6736742d8c242acf5f
Comment 1 Jordan Petridis 2018-10-29 21:41:09 UTC
Created attachment 374100 [details] [review]
meson: declare variables
Comment 2 GStreamer system administrator 2018-11-03 14:37:10 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/809.