After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 797340 - udpsrc: print information about bind_error socket error
udpsrc: print information about bind_error socket error
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
1.14.x
Other Linux
: Normal enhancement
: 1.15.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-10-27 10:46 UTC by Marc Leeman
Modified: 2018-10-27 12:14 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gstudpsrc: print information about bind_error socket error (1.16 KB, patch)
2018-10-27 10:46 UTC, Marc Leeman
none Details | Review
gstudpsrc: print information about bind_error socket error (1.17 KB, patch)
2018-10-27 11:26 UTC, Marc Leeman
committed Details | Review

Description Marc Leeman 2018-10-27 10:46:00 UTC
Created attachment 374055 [details] [review]
gstudpsrc: print information about bind_error socket error

In some cases, a bind error occurs during operation. Printing
the information about the problem is critical for finding the
conflict
Comment 1 Sebastian Dröge (slomo) 2018-10-27 11:06:26 UTC
Review of attachment 374055 [details] [review]:

::: gst/udp/gstudpsrc.c
@@ +1356,3 @@
     g_object_unref (bind_addr);
+    if (!g_socket_bind (src->used_socket, bind_saddr, src->reuse, &err)) {
+      GST_ERROR_OBJECT (src, "Error binding to %s:%d", src->address, src->port);

Should probably also print err->message?
Comment 2 Marc Leeman 2018-10-27 11:26:56 UTC
Created attachment 374056 [details] [review]
gstudpsrc: print information about bind_error socket error
Comment 3 Sebastian Dröge (slomo) 2018-10-27 12:13:48 UTC
commit 827d70daeec06e66d14c7c209f8f06683280184a
Author: Marc Leeman <marc.leeman@gmail.com>
Date:   Wed May 16 14:15:13 2018 +0200

    udpsrc: print information about bind_error socket error
    
    In some cases, a bind error occurs during operation. Printing
    the information about the problem is critical for finding the
    conflict
    
    https://bugzilla.gnome.org/show_bug.cgi?id=797340