GNOME Bugzilla – Bug 797335
Building pkg-config files always happens with silent rules; doesn't respect --disable-silent-rules
Last modified: 2018-11-03 12:49:05 UTC
Created attachment 374036 [details] [review] patch If I configure gstreamer 1.14.4 or 0.10.36 with --disable-silent-rules, silent rules are disabled, except for the part that "builds" (copies) the pkg-config .pc files; this part always displays e.g. " CP gstreamer-1.0.pc" instead of the actual cp command like I wanted it to. I've attached what I believe to be the correct fix for gstreamer, but it looks like the problem affects the plugins as well and should be committed to each of them. I did not check all of your repositories so I don't know where all the fix is needed. I did see that gst-libav already includes this fix, and that some others like gst-editing-services and gst-rtsp-server appear (based on looking at the source code only) to have the opposite problem of always using non-silent rules. It would be good to get the pkgconfig/Makefile.am files of all of the repositories that use it to be consistent.
Thanks for the patch! Please provide patches in "git format-patch" format, see https://gstreamer.freedesktop.org/documentation/contribute/index.html#how-to-submit-patches
I really don't want to jump through any more hoops to contribute.... I've already contributed the necessary code change.
This is so you get attributed properly as the author.
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gstreamer/issues/322.