GNOME Bugzilla – Bug 797320
Skip C-specific constants from gir generation
Last modified: 2018-10-23 15:24:53 UTC
Created attachment 373998 [details] [review] patch to skip gst-error-system from gir generation The following constants are not useful outside of C and currently cause some tests of the rust bindings to fail. GST_ERROR_SYSTEM GST_PTR_FORMAT GST_SEGMENT_FORMAT GST_STIME_FORMAT
Created attachment 373999 [details] [review] skip format specifier from gir generation
Created attachment 374000 [details] [review] skip gst strime format from gir generation
Review of attachment 373999 [details] [review]: There's also GST_TIME_FORMAT, GST_TIME_ARGS, GST_STIME_FORMAT, GST_STIME_ARGS, GST_FOURCC_FORMAT
Review of attachment 373999 [details] [review]: And GST_FOURCC_ARGS
Review of attachment 374000 [details] [review]: See comment about the second patch. These second and this patch should be merged into one, it's all the same problem :)
Created attachment 374011 [details] [review] Skip all the format specifiers requested
commit 9251cd9bf502aa2f218b8cfc65e85439133e4a05 (HEAD -> master, origin/master, origin/HEAD) Author: Jordan Petridis <jordan@centricular.com> Date: Tue Oct 16 19:35:03 2018 +0300 gst: skip format specifiers from gir generation GST_TIME_FORMAT, GST_TIME_ARGS, GST_STIME_FORMAT, GST_STIME_ARGS GST_PTR_FORMAT, GST_SEGMENT_FORMAT, GST_FOURCC_FORMAT and GST_FOURCC_ARGS are format specifiers. They can't be used outside of C and should be generated in the gir. https://bugzilla.gnome.org/show_bug.cgi?id=797320 commit cd6ceb1c41729fcedb0baaae94f60f477d700fe2 Author: Jordan Petridis <jordan@centricular.com> Date: Tue Oct 16 19:35:03 2018 +0300 gst/gsterror.h: skip GST_ERROR_SYSTEM during gir generation GST_ERROR_SYSTEM can't really be used outside of C and should be skipped. https://bugzilla.gnome.org/show_bug.cgi?id=797320