GNOME Bugzilla – Bug 797315
Add support gst-libav build on MSVC using downloaded prebuilt ffmpeg
Last modified: 2018-11-03 11:05:19 UTC
On windows, installing ffmpeg and building gst-libav requires more effort compared to *nix environment. This patch will make it easier on Windows MSVC build. (but user should add ffmpeg's dll path to %PATH% env. manually when 'uninstalled' environment is required)
Created attachment 373983 [details] [review] Add support gst-libav build on MSVC using downloaded prebuilt ffmpeg
(In reply to Seungha Yang from comment #1) > Created attachment 373983 [details] [review] [review] > Add support gst-libav build on MSVC using downloaded prebuilt ffmpeg This needs more work since meson trigger download script always regardless of meson option...
Created attachment 373992 [details] [review] Add support gst-libav build on MSVC using downloaded prebuilt ffmpeg On windows, installing ffmpeg and building gst-libav requires more effort compared to *nix environment. This patch will make it easier on Windows MSVC build. To enable this, run meson build with '-D download_prebuilt_ffmpeg=true' * Auto detect prebuilt ffmpeg dll path and set it to env for 'uninstalled' use case. * Use copy hack to avoid unwanted 'FFmpeg' subproject fallback depending on download_prebuilt_ffmpeg option.
Are these prebuilt LGPL compliant? If you later want to distribute, you need to be able to rebuild it, and provide the scripts to do so. I'm not against, I simply have this concern that I don't want to support people shipping binary they have no idea how to build.
(In reply to Nicolas Dufresne (ndufresne) from comment #4) > Are these prebuilt LGPL compliant? If you later want to distribute, you need > to be able to rebuild it, and provide the scripts to do so. I'm not against, > I simply have this concern that I don't want to support people shipping > binary they have no idea how to build. The binaries are GPL license compliant like binaries via apt-get. I hope this option to be used just for testing purpose rather than for distribution. I just thought that "wanna make building gst-libav on Windows simple as much as possible". Actually, cerbero requires more effort and it's heavy... License issue makes me a little confused, especially because we moved to shared ffmpeg lib from static lib recently.
Noted. About the license, all that matters (personal non lawyer view) is that you must only link against GPL build of ffmpeg if targetting GPL application. So if that build is GPL rather then LGPL, and you would want to distribute, then GStreamer is to be considered GPL with the limitations. I guess we should look forward a run-time warning to help in this regard. For GStreamer, GPL plugins are place in -ugly repository along with highly patented code. Meanwhile I'm in favour of this, I'd say Nirbheek should bring his input first though.
Created attachment 374109 [details] [review] Add support gst-libav build on MSVC using downloaded prebuilt ffmpeg rebased
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-build/issues/9.