After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 797298 - meson: Replace empty configuration_data() with copy keyword
meson: Replace empty configuration_data() with copy keyword
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Windows
: Normal minor
: 1.15.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-10-17 12:12 UTC by Seungha Yang
Modified: 2018-10-17 13:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
-base: meson: Replace empty configuration_data() with copy keyword (3.85 KB, patch)
2018-10-17 12:14 UTC, Seungha Yang 		committed Details | Review
-bad: meson: Replace empty configuration_data() with copy keyword (2.70 KB, patch)
2018-10-17 12:15 UTC, Seungha Yang 		committed Details | Review

Description Seungha Yang 2018-10-17 12:12:56 UTC 
Use 'copy' keyword to avoid meson warning message.
Note that 'copy' keyword in configure_file() is available
since meson 0.47.0
Comment 1 Seungha Yang 2018-10-17 12:14:42 UTC 
Created attachment 373950 [details] [review]
-base: meson: Replace empty configuration_data() with copy keyword
Comment 2 Seungha Yang 2018-10-17 12:15:18 UTC 
Created attachment 373951 [details] [review]
-bad: meson: Replace empty configuration_data() with copy keyword
Comment 3 Tim-Philipp Müller 2018-10-17 12:59:10 UTC 
Comment on attachment 373950 [details] [review]
-base: meson: Replace empty configuration_data() with copy keyword

commit 3499d9ea646311a879813fa033226b7624d9e1eb
Author: Seungha Yang <seungha.yang@navercorp.com>
Date:   Thu Sep 27 21:21:14 2018 +0900

    meson: Replace empty configuration_data() with copy keyword
    
    Use 'copy' keyword to avoid meson warning message.
    Note that 'copy' keyword in configure_file() is available
    since meson 0.47.0
    
    https://bugzilla.gnome.org/show_bug.cgi?id=797298
Comment 4 Tim-Philipp Müller 2018-10-17 13:09:57 UTC 
Thanks!

-bad:

commit 53b6c94d630c35b44226a3c3510955c1fc20f4b6
Author: Seungha Yang <seungha.yang@navercorp.com>
Date:   Wed Oct 17 21:09:22 2018 +0900

    meson: Replace empty configuration_data() with copy keyword
    
    Use 'copy' keyword to avoid meson warning message.
    Note that 'copy' keyword in configure_file() is available
    since meson 0.47.0
    
    https://bugzilla.gnome.org/show_bug.cgi?id=797298
Comment 5 Tim-Philipp Müller 2018-10-17 13:16:48 UTC 
-good:

commit cac9aab107176b0398a10d2bdaca23909fd107e1
Author: Tim-Philipp Müller <tim@centricular.com>
Date:   Wed Oct 17 14:15:33 2018 +0100

    meson: Replace empty configuration_data() with copy keyword
    
    Use 'copy' keyword to avoid meson warning message.
    Note that 'copy' keyword in configure_file() is available
    since meson 0.47.0
    
    https://bugzilla.gnome.org/show_bug.cgi?id=797298