After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 797293 - splitmuxsink: Do not hardcode frames_of_daily_jam
splitmuxsink: Do not hardcode frames_of_daily_jam
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other All
: Normal normal
: 1.15.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-10-16 12:44 UTC by Vivia Nikolaidou
Modified: 2018-10-16 13:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
splitmuxsink: Do not hardcode frames_of_daily_jam (3.31 KB, patch)
2018-10-16 12:44 UTC, Vivia Nikolaidou
committed Details | Review

Description Vivia Nikolaidou 2018-10-16 12:44:29 UTC
See commit message
Comment 1 Vivia Nikolaidou 2018-10-16 12:44:34 UTC
Created attachment 373942 [details] [review]
splitmuxsink: Do not hardcode frames_of_daily_jam

Apart from the obvious drawbacks of hardcoding, the drawback here was
that, if we subtracted 2 frames (instead of 2.6) from the target running
time, we'd request the next keyframe a bit too far into the future,
which would make our files split at the wrong position.
Comment 2 Sebastian Dröge (slomo) 2018-10-16 12:55:55 UTC
Review of attachment 373942 [details] [review]:

Makes sense
Comment 3 Vivia Nikolaidou 2018-10-16 13:08:06 UTC
Review of attachment 373942 [details] [review]:

commit af0e30d5452d87117dd6371fd15e213af5524ac4 (HEAD -> master, origin/master, origin/HEAD)
Author: Vivia Nikolaidou <vivia@ahiru.eu>
Date:   Tue Oct 16 15:42:12 2018 +0300

    splitmuxsink: Do not hardcode frames_of_daily_jam

    Apart from the obvious drawbacks of hardcoding, the drawback here was
    that, if we subtracted 2 frames (instead of 2.6) from the target running
    time, we'd request the next keyframe a bit too far into the future,
    which would make our files split at the wrong position.

    https://bugzilla.gnome.org/show_bug.cgi?id=797293