After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 797291 - tests: pipeline processing deadline unit test fails in valgrind
tests: pipeline processing deadline unit test fails in valgrind
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal blocker
: 1.15.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-10-16 11:22 UTC by Tim-Philipp Müller
Modified: 2018-10-17 20:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Tim-Philipp Müller 2018-10-16 11:22:38 UTC 
For me the new test_pipeline_processing_deadline unit test reliably fails in valgrind, e.g.:

$ GST_CHECKS=test_pipeline_processing_deadline make gst/gstpipeline.valgrind
Running suite(s): GstPipeline
0%: Checks: 1, Failures: 1, Errors: 0
gst/gstpipeline.c:721:F:pipeline tests:test_pipeline_processing_deadline:0: Pipeline position is not at least 50millisecond (reported 149976914 nanoseconds)

$ GST_CHECKS=test_pipeline_processing_deadline make gst/gstpipeline.valgrind
Running suite(s): GstPipeline
gst/gstpipeline.c:721:F:pipeline tests:test_pipeline_processing_deadline:0: Pipeline position is not at least 50millisecond (reported 90000000 nanoseconds)

Wonder if this is expected e.g. due to tight timing and scheduling shenanigans, or something that needs fixing or if the test should be skipped if we're running in valgrind?
Comment 1 Olivier Crête 2018-10-17 20:44:04 UTC 
I replaced the wait with a GstTestClock, I wonder why I didn't use that in the first place!
Comment 2 Olivier Crête 2018-10-17 20:44:31 UTC 
Commit is:

commit 5658ae998606a180539d970701bd72a45d59370b
Author: Olivier Crête <olivier.crete@collabora.com>
Date:   Wed Oct 17 16:38:42 2018 -0400

    tests: Use GstTestClock for processing-deadline test
    
    Use the test clock instead of using a real one to make it
    easier to run in valgrind.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=797291