After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 797275 - flvdemux: Use aac codec-data to adjust channels if needed
flvdemux: Use aac codec-data to adjust channels if needed
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 1.15.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-10-11 07:53 UTC by Yeongjin Jeong
Modified: 2018-10-12 18:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
flvdemux: Use aac codec-data to adjust channels if needed (1.80 KB, patch)
2018-10-11 07:53 UTC, Yeongjin Jeong 		committed Details | Review
tests: flvdemux: Add new test for channel detect using aac codec-data (5.85 KB, patch)
2018-10-12 13:58 UTC, Yeongjin Jeong 		committed Details | Review

Description Yeongjin Jeong 2018-10-11 07:53:35 UTC 
Created attachment 373893 [details] [review]
flvdemux: Use aac codec-data to adjust channels if needed

Flv does not support various channels in AAC stream format, for example flvdemux detect an audio channels of 2(stereo) when the AAC really is 1(mono).
Comment 1 Olivier Crête 2018-10-11 19:42:32 UTC 
Do you have a small test? maybe just the header of such a file? Like one with just an audio stream?

Otherwise the patch looks good to me.
Comment 2 Yeongjin Jeong 2018-10-12 13:52:14 UTC 
(In reply to Olivier Crête from comment #1)
> Do you have a small test? maybe just the header of such a file? Like one
> with just an audio stream?
> 
> Otherwise the patch looks good to me.

Okay, I will upload a simple test. :)
Comment 3 Yeongjin Jeong 2018-10-12 13:58:35 UTC 
Created attachment 373910 [details] [review]
tests: flvdemux: Add new test for channel detect using aac codec-data

Add test case to verify channel detect using aac codec-data.

The FLV packet used in this test was created using gst-launch as follows:

gst-launch-1.0 audiotestsrc ! audio/x-raw, rate=22050, channels=1 ! fdkaacenc ! flvmux streamable=true ! fakesink
Comment 4 Olivier Crête 2018-10-12 18:41:53 UTC 
Thank you for your contribution!

Attachment 373893 [details] pushed as bd6a4aa - flvdemux: Use aac codec-data to adjust channels if needed
Attachment 373910 [details] pushed as afa4be4 - tests: flvdemux: Add new test for channel detect using aac codec-data