GNOME Bugzilla – Bug 797267
video: add new Y210 pixel format (packed 4:2:2, 10-bit)
Last modified: 2018-11-15 14:40:15 UTC
The format defined in: https://docs.microsoft.com/en-us/windows/desktop/medfound/10-bit-and-16-bit-yuv-video-formats
Created attachment 373880 [details] [review] Add Y210 pixel format support.
How does this differ from v210?
v210 https://wiki.multimedia.cx/index.php/V210 The order differ, v210 is UYVY, Y210 is YUYV. The also, the packing if different. v210 packs over 32 bit, 2 distributed padding bit, while Y210 uses 6bits padding per components (like all the other MS formats). Please make sure to run make check / ninja test. We have a generic test for pixels formats which is very good at catching any errors.
(In reply to Nicolas Dufresne (ndufresne) from comment #3) > v210 > https://wiki.multimedia.cx/index.php/V210 > > The order differ, v210 is UYVY, Y210 is YUYV. The also, the packing if > different. v210 packs over 32 bit, 2 distributed padding bit, while Y210 > uses 6bits padding per components (like all the other MS formats). > > Please make sure to run make check / ninja test. We have a generic test for > pixels formats which is very good at catching any errors. Thanks ndufresne for your clear explain. Also, make check looks good for this patch.
Hi, could someone help to review this patch? Our next task(https://bugzilla.gnome.org/show_bug.cgi?id=797264) is blocked by this patch. Thanks~
I'm more busy then usual, but lately I took care of new pixel formats. This one seems fine, the name is horrible though, but as it's referenced by Microsoft this way, let's keep it. In any case, feel free to start implementing the vaapi bits, Victor could then merge these two together.
(In reply to Nicolas Dufresne (ndufresne) from comment #6) > I'm more busy then usual, but lately I took care of new pixel formats. This > one seems fine, the name is horrible though, but as it's referenced by > Microsoft this way, let's keep it. In any case, feel free to start > implementing the vaapi bits, Victor could then merge these two together. Thanks ndufresne, I will ping Victor to help merge two patch together after I finished gst-vaapi side one.
Patch looked good, manual tests showed that it works, so I merged it. I have fixed typos in the commit message. commit cc0bcd585626ac1d01cde4258420325a535c0962 (HEAD -> master, origin/master, origin/HEAD) Author: Wangfei <fei.w.wang@intel.com> Date: Tue Oct 9 15:25:37 2018 +0800 video: add Y210 pixel format. This pixel format is packed format with 4:2:2 sample and 10 available bits of each channel. https://bugzilla.gnome.org/show_bug.cgi?id=797267
Review of attachment 373880 [details] [review]: ::: gst-libs/gst/video/video-format.h @@ +142,3 @@ GST_VIDEO_FORMAT_v210, GST_VIDEO_FORMAT_v216, + GST_VIDEO_FORMAT_Y210, This breaks ABI, it must be added at the end
Oops, complete missed that one, I'll send an Mr if no one beats me at it.