After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 797247 - Missing include in matroska-read-common.c
Missing include in matroska-read-common.c
Status: RESOLVED INVALID
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-10-04 07:22 UTC by Johan Bjäreholt
Modified: 2018-10-04 13:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
0001-Added-missing-gstprotection.h-include.patch (697 bytes, patch)
2018-10-04 07:22 UTC, Johan Bjäreholt 		reviewed Details | Review

Description Johan Bjäreholt 2018-10-04 07:22:20 UTC 
Created attachment 373842 [details] [review]
0001-Added-missing-gstprotection.h-include.patch

GST_PROTECTION_UNSPECIFIED_SYSTEM_ID is not included anywhere so trying to compile without this patch gives me a undefined variable error.
Comment 1 Sebastian Dröge (slomo) 2018-10-04 07:36:40 UTC 
Comment on attachment 373842 [details] [review]
0001-Added-missing-gstprotection.h-include.patch

This should not really be needed, it should already be included by gst/gst.h
Comment 2 Sebastian Dröge (slomo) 2018-10-04 07:37:40 UTC 
And it is, line 69 of gst.h. Can you check why this doesn't happen for you?
Comment 3 Johan Bjäreholt 2018-10-04 07:50:47 UTC 
Hm, that is odd.

Will investigate what's wrong with my environment and get back to you.
Comment 4 Johan Bjäreholt 2018-10-04 13:00:43 UTC 
Definitely an environment issue, closing