After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 797236 - Auto-set introspection options for Meson recipes
Auto-set introspection options for Meson recipes
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: cerbero
unspecified
Other All
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-10-02 06:08 UTC by Nirbheek Chauhan
Modified: 2018-10-03 12:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
cerbero: auto-set introspection options for meson (3.29 KB, patch)
2018-10-02 06:08 UTC, Nirbheek Chauhan 		committed Details | Review
json-glib.recipe: Update to 1.4.4 (1.36 KB, patch)
2018-10-02 06:08 UTC, Nirbheek Chauhan 		committed Details | Review

Description Nirbheek Chauhan 2018-10-02 06:08:07 UTC 
This is needed for porting more recipes to Meson.
Comment 1 Nirbheek Chauhan 2018-10-02 06:08:13 UTC 
Created attachment 373823 [details] [review]
cerbero: auto-set introspection options for meson

This makes meson recipes have the same behaviour as Autotools recipes.
Comment 2 Nirbheek Chauhan 2018-10-02 06:08:18 UTC 
Created attachment 373824 [details] [review]
json-glib.recipe: Update to 1.4.4

Upstream has dropped autotools.
Comment 3 Olivier Crête 2018-10-02 15:50:19 UTC 
Review of attachment 373823 [details] [review]:

This parsing of meson_options is incredibly ugly.. You really need to have meson provide this to us.
Comment 4 Nirbheek Chauhan 2018-10-03 12:07:52 UTC 
(In reply to Olivier Crête from comment #3)
> Review of attachment 373823 [details] [review] [review]:
> 
> This parsing of meson_options is incredibly ugly.. You really need to have
> meson provide this to us.

Yes, but we can't block on upstream adding an interface for it and then waiting for it to reach a release. The alternative, of course, is to duplicate this logic in every recipe but that's less clean than doing this now and then replacing it once upstream fixes it.

Note that this is not any different than autotools in which we just always pass --enable/disable-introspection without even checking if that option exists. Difference is, there we just get a warning.
Comment 5 Nirbheek Chauhan 2018-10-03 12:08:54 UTC 
Attachment 373823 [details] pushed as d253fef - cerbero: auto-set introspection options for meson
Attachment 373824 [details] pushed as 86d8026 - json-glib.recipe: Update to 1.4.4
Comment 6 Nirbheek Chauhan 2018-10-03 12:10:23 UTC 
Also, the long-term fix for this is to have all projects use feature options for introspection, and to call the option 'introspection'. F.ex., gdk-pixbuf calls it 'gir'.