After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 797226 - gst: Fix string leak when G_VALUE_COLLECT_INIT() was failed
gst: Fix string leak when G_VALUE_COLLECT_INIT() was failed
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-09-29 09:59 UTC by Seungha Yang
Modified: 2018-11-03 12:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gst: Fix string leak when G_VALUE_COLLECT_INIT() was failed (2.37 KB, patch)
2018-09-29 10:00 UTC, Seungha Yang 		none Details | Review
tests: caps: Add more broken caps test case (936 bytes, patch)
2018-09-29 10:01 UTC, Seungha Yang 		reviewed Details | Review

Description Seungha Yang 2018-09-29 09:59:27 UTC 
Returned string should be freed
Comment 1 Seungha Yang 2018-09-29 10:00:54 UTC 
Created attachment 373808 [details] [review]
gst: Fix string leak when G_VALUE_COLLECT_INIT() was failed
Comment 2 Seungha Yang 2018-09-29 10:01:20 UTC 
Created attachment 373809 [details] [review]
tests: caps: Add more broken caps test case
Comment 3 Tim-Philipp Müller 2018-10-03 18:07:49 UTC 
Comment on attachment 373809 [details] [review]
tests: caps: Add more broken caps test case

>+      gst_caps_new_simple ("test/wrong-field",
>+          "foo", GST_TYPE_FRACTION, "bar", NULL));

I think this is misleading - what assertion does this produce for you?

If we want to exercise the "passed '0' as denominator for `GstFraction'" error code path, then we should pass a proper fraction with a 0 denominator, not wrong code which may or may not crash depending on how it's handled.
Comment 4 GStreamer system administrator 2018-11-03 12:48:49 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gstreamer/issues/319.