GNOME Bugzilla – Bug 797218
queuearray: Add set_clear_func and clear functions
Last modified: 2018-10-15 12:30:04 UTC
See commit message
Created attachment 373791 [details] [review] queuearray: Add set_clear_func and clear functions gst_queue_array_clear will clear the GstQueueArray, gst_queue_array_set_clear_func will set a clear function for each element to be called on _clear and on _free.
Review of attachment 373791 [details] [review]: Looks good but the new functions should be added to the docs (docs/libs/*-sections.txt)
Created attachment 373795 [details] [review] queuearray: Add set_clear_func and clear functions gst_queue_array_clear will clear the GstQueueArray, gst_queue_array_set_clear_func will set a clear function for each element to be called on _clear and on _free.
Created attachment 373796 [details] [review] queuearray: Add set_clear_func and clear functions gst_queue_array_clear will clear the GstQueueArray, gst_queue_array_set_clear_func will set a clear function for each element to be called on _clear and on _free.
Review of attachment 373796 [details] [review]: commit 22d0f407168d1c64621218b29f481f0346b4f59c (HEAD -> upstream_master, upstream/master) Author: Vivia Nikolaidou <vivia@ahiru.eu> Date: Thu Sep 27 17:30:25 2018 +0300 queuearray: Add set_clear_func and clear functions gst_queue_array_clear will clear the GstQueueArray, gst_queue_array_set_clear_func will set a clear function for each element to be called on _clear and on _free. https://bugzilla.gnome.org/show_bug.cgi?id=797218
This one was missing, dropping an item did not clear it. Now clear(), free() and drop() is going to call the clear function, while pop() is not, and all other functions are not removing an item from the queue. commit 2481e542c76f1392f577b8daff05fdcba324597c (HEAD -> master) Author: Sebastian Dröge <sebastian@centricular.com> Date: Mon Oct 15 15:24:07 2018 +0300 queuearray: Clear items when dropping them and a clear function was defined