After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 797215 - tagdemux: Use upstream GST_EVENT_STREAM_START if present
tagdemux: Use upstream GST_EVENT_STREAM_START if present
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other All
: Normal normal
: 1.14.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-09-27 13:09 UTC by Edward Hervey
Modified: 2018-09-27 19:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
tagdemux: Use upstream GST_EVENT_STREAM_START if present (2.41 KB, patch)
2018-09-27 13:09 UTC, Edward Hervey
committed Details | Review

Description Edward Hervey 2018-09-27 13:09:00 UTC
See commit
Comment 1 Edward Hervey 2018-09-27 13:09:05 UTC
Created attachment 373786 [details] [review]
tagdemux: Use upstream GST_EVENT_STREAM_START if present

If we have an upstream GST_EVENT_STREAM_START, use that one instead
of creating a new one which could be completely different from the
upstream one and drop information (like the stream flags and stream
object).

Only create a new event if we don't already have one from upstream
Comment 2 Sebastian Dröge (slomo) 2018-09-27 13:29:51 UTC
Review of attachment 373786 [details] [review]:

Why did we even have that old code there?! :)
Comment 3 Edward Hervey 2018-09-27 13:38:25 UTC
Attachment 373786 [details] pushed as 8707914 - tagdemux: Use upstream GST_EVENT_STREAM_START if present