After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 797212 - Add GstBuffer helper for wrapping a GBytes
Add GstBuffer helper for wrapping a GBytes
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
unspecified
Other Linux
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-09-27 10:32 UTC by Matthew Waters (ystreet00)
Modified: 2018-11-03 12:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gst/buffer: add a helper for wrapping a GBytes (3.45 KB, patch)
2018-09-27 10:33 UTC, Matthew Waters (ystreet00) 		accepted-commit_now Details | Review

Description Matthew Waters (ystreet00) 2018-09-27 10:32:22 UTC 
See commit
Comment 1 Matthew Waters (ystreet00) 2018-09-27 10:33:53 UTC 
Created attachment 373784 [details] [review]
gst/buffer: add a helper for wrapping a GBytes
Comment 2 Tim-Philipp Müller 2018-09-27 10:46:40 UTC 
Looks good to me.

<bikeshed:on>

Was wondering if we should keep the _wrapped part in the name for consistency or just call it new_from_bytes() instead which would be consistent with other API patterns.

<bikeshed:off>
Comment 3 Sebastian Dröge (slomo) 2018-09-27 10:52:12 UTC 
Comment on attachment 373784 [details] [review]
gst/buffer: add a helper for wrapping a GBytes

Looks good to me, also the name :)
Comment 4 Tim-Philipp Müller 2018-10-03 23:32:39 UTC 
Comment on attachment 373784 [details] [review]
gst/buffer: add a helper for wrapping a GBytes

Let's get it in then :)
Comment 5 Tim-Philipp Müller 2018-10-11 23:34:43 UTC 
pingo?
Comment 6 GStreamer system administrator 2018-11-03 12:48:44 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gstreamer/issues/318.