After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 797211 - msdk: Fix building on MSVC
msdk: Fix building on MSVC
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Windows
: Normal normal
: 1.14.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-09-27 06:40 UTC by Seungha Yang
Modified: 2018-10-01 22:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
msdk: Fix meson build (726 bytes, patch)
2018-09-27 06:42 UTC, Seungha Yang 		committed Details | Review
msdk: Fix building on MSVC (2.47 KB, patch)
2018-09-27 06:42 UTC, Seungha Yang 		committed Details | Review

Description Seungha Yang 2018-09-27 06:40:21 UTC 
And add missing #ifdef _WIN32 for MSVC build
Comment 1 Seungha Yang 2018-09-27 06:42:25 UTC 
Created attachment 373781 [details] [review]
msdk: Fix meson build

gst-plugins-bad\sys\msdk\meson.build:57:4: ERROR:  File msdk-enum.c does not exist.
Comment 2 Seungha Yang 2018-09-27 06:42:58 UTC 
Created attachment 373782 [details] [review]
msdk: Fix building on MSVC
Comment 3 Nirbheek Chauhan 2018-10-01 22:35:02 UTC 
Thanks for the patches!

Attachment 373781 [details] pushed as 44ecf53 - msdk: Fix meson build
Attachment 373782 [details] pushed as f106a10 - msdk: Fix building on MSVC
Comment 4 Nirbheek Chauhan 2018-10-01 22:38:12 UTC 
f106a10 also cherry-picked as db25ec317 to the 1.14 branch.