After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 797191 - qtdemux: turn impossible condition into an assert
qtdemux: turn impossible condition into an assert
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other All
: Normal normal
: 1.15.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-09-22 15:32 UTC by Alicia Boya García
Modified: 2018-09-24 07:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
qtdemux: turn impossible condition into an assert (1.50 KB, patch)
2018-09-22 15:32 UTC, Alicia Boya García 		committed Details | Review

Description Alicia Boya García 2018-09-22 15:32:03 UTC 
qtdemux_update_streams() is only ever called after checking
`qtdemux->streams_aware` is TRUE. There is no need to check for that
condition again.

`qtdemux->streams_aware` is only modified when the demuxer is
hard-resetted, which is mutually exclusive with demuxing, so it cannot
be modified during the call.
Comment 1 Alicia Boya García 2018-09-22 15:32:08 UTC 
Created attachment 373738 [details] [review]
qtdemux: turn impossible condition into an assert
Comment 2 Tim-Philipp Müller 2018-09-24 07:35:11 UTC 
Thanks!

commit bc0ea0dbbb4a5f10daa5292f1da4613584d5e3ae
Author: Alicia Boya García <aboya@igalia.com>
Date:   Sat Sep 22 17:22:46 2018 +0200

    qtdemux: turn impossible condition into an assert
    
    qtdemux_update_streams() is only ever called after checking
    `qtdemux->streams_aware` is TRUE. There is no need to check for that
    condition again.
    
    `qtdemux->streams_aware` is only modified when the demuxer is
    hard-resetted, which is mutually exclusive with demuxing, so it cannot
    be modified during the call.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=797191