After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 797184 - gl/win32: Use g_io_channel_win32_new_messages() instead of our custom GSource
gl/win32: Use g_io_channel_win32_new_messages() instead of our custom GSource
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other All
: Normal enhancement
: 1.15.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-09-21 08:30 UTC by Sebastian Dröge (slomo)
Modified: 2018-09-21 11:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gl/win32: Use g_io_channel_win32_new_messages() instead of our custom GSource (8.35 KB, patch)
2018-09-21 08:30 UTC, Sebastian Dröge (slomo) 		none Details | Review
gl/win32: Use g_io_channel_win32_new_messages() instead of our custom GSource (8.40 KB, patch)
2018-09-21 08:57 UTC, Sebastian Dröge (slomo) 		committed Details | Review

Description Sebastian Dröge (slomo) 2018-09-21 08:30:22 UTC 
Note that this is untested so far, even for compilation.
Comment 1 Sebastian Dröge (slomo) 2018-09-21 08:30:28 UTC 
Created attachment 373717 [details] [review]
gl/win32: Use g_io_channel_win32_new_messages() instead of our custom GSource

Removes some unneeded code duplication between here and GLib.
Comment 2 Sebastian Dröge (slomo) 2018-09-21 08:57:06 UTC 
Created attachment 373718 [details] [review]
gl/win32: Use g_io_channel_win32_new_messages() instead of our custom GSource

Removes some unneeded code duplication between here and GLib.
Comment 3 Sebastian Dröge (slomo) 2018-09-21 10:00:35 UTC 
Confirmed to compile at least
Comment 4 Sebastian Dröge (slomo) 2018-09-21 11:44:07 UTC 
Attachment 373718 [details] pushed as cde4cfe - gl/win32: Use g_io_channel_win32_new_messages() instead of our custom GSource