GNOME Bugzilla – Bug 797178
Folder containment for config.h file
Last modified: 2018-09-19 18:17:52 UTC
I am writing some C++ code which consumes GES (gst-editing-services). As you can imagine, I appreciate the fact that most of the header files are contained under a `gst` or `ges` folder. But there is one auto-generated file where this principle of containment has been violated. It is a generated file called "config.h". It would be great if someone could put "config.h" under the "ges" folder. I don't understand enough about the build to do it myself. There are multiple build systems, none of which I understand. Here is a helpful grep from Gstreamer 1.14.2 $ grep -IPrn --include={*.h,*.c} 'include[^\n]+config\.h' examples/c/thumbnails.c:21:#include "config.h" tools/ges-validate.c:22:#include "config.h" tools/ges-launcher.c:21:#include "config.h" plugins/nle/nleobject.c:22:#include "config.h" plugins/nle/gstnle.c:25:#include "config.h" plugins/nle/nlesource.c:23:#include "config.h" plugins/nle/nleurisource.c:22:#include "config.h" plugins/nle/nleghostpad.c:21:#include "config.h" plugins/nle/nleoperation.c:23:#include "config.h" plugins/nle/nlecomposition.c:24:#include "config.h" ges/ges.c:30:#include "config.h" ges/gstframepositioner.c:21:#include "config.h" ges/ges-validate.c:22:#include "config.h"
But what are you hoping to fix with this? Having a generated config.h in the top level build dir is pretty much standard, I know very few projects that don't do this, and there is nothing wrong with it either.
Note that config.h is not installed and not used in any of the installed public headers.
You are right ... I should have noticed that none of the other headers were pulling it in. The bug should be closed.
I am closing this because I should never have filed it.