GNOME Bugzilla – Bug 797171
omx: log OMX commands and events
Last modified: 2018-09-26 07:22:51 UTC
We often found the need to have a clear view of the OMX <-> gst exchanges while debugging. We were having a good view of the buffer exchanges thanks to the OMX_PERFORMANCE debug cat but not the commands and events. So I extended it and renamed it to OMX_API_TRACE as it's now more generic.
Created attachment 373697 [details] [review] omx: rename log_omx_performance() to log_omx_performance_buffer() I'm about to log more things under this category
Created attachment 373698 [details] [review] omx: log OMX events with OMX_PERFORMANCE debug category It has been useful to have a clear raw and structured view of the gst <-> OMX exchanges when debugging.
Created attachment 373699 [details] [review] omx: factor out gst_omx_component_send_command() No semantic change. I'm going to add extra debug in this function.
Created attachment 373700 [details] [review] omx: log OMX commands with OMX_PERFORMANCE debug category It has been useful to have a clear raw and structured view of the gst <-> OMX exchanges when debugging.
Created attachment 373701 [details] [review] omx: rename OMX_PERFORMANCE debug cat to OMX_API_TRACE This debug category can now be used to track more OMX calls and events so best to rename it to something more generic.
Review of attachment 373697 [details] [review]: .
Review of attachment 373698 [details] [review]: .
Review of attachment 373699 [details] [review]: .
Review of attachment 373700 [details] [review]: .
Review of attachment 373701 [details] [review]: This is a first step, should be rename the functions too ?
(In reply to Nicolas Dufresne (ndufresne) from comment #10) > Review of attachment 373701 [details] [review] [review]: > > This is a first step, should be rename the functions too ? Good point. I renamed them to log_omx_api_trace_*
Attachment 373697 [details] pushed as 313deb4 - omx: rename log_omx_performance() to log_omx_performance_buffer() Attachment 373698 [details] pushed as 9b1598e - omx: log OMX events with OMX_PERFORMANCE debug category Attachment 373699 [details] pushed as 68f1834 - omx: factor out gst_omx_component_send_command() Attachment 373700 [details] pushed as 3a16094 - omx: log OMX commands with OMX_PERFORMANCE debug category Attachment 373701 [details] pushed as 6207459 - omx: rename OMX_PERFORMANCE debug cat to OMX_API_TRACE