GNOME Bugzilla – Bug 797097
Download gstreamer tarballs for releases instead of cloning the repo
Last modified: 2018-09-11 14:07:02 UTC
This should make releases much faster to download and build for users, and should make it much easier to do releases as well, since now you only need to update the version in packages/custom.py and recipes/custom.py, and for a release tag, set tagged_for_release = True in recipes/custom.py.
After the release is tagged, set tagged_for_release = False and make a new commit. This will cause recipes to fetch the latest HEAD of the (stable) branch instead.
Created attachment 373559 [details] [review]
gstreamer recipes: Centralize the source download logic
Move the logic to custom.py, and toggle between origin/master,
origin/1.xy (stable branches) and tarballs based on the version and
the `tagged_for_release` property on the custom.GStreamer class.
Also replace self.name in git URLs similar to tarball URLs.
Now, the way to do releases is to set tagged_for_release = True, which
will force Cerbero to download tarballs instead of git repositories.
Another good reason to do this is to ensure that our generated tarballs have all the necessary files to build on all platforms.
Good Idea (haven't reviewed anything though). We should still eventually teach bundle_source to use git-archive for the other use cases.
Review of attachment 373559 [details] [review]:
Looks good to me.
Thanks for the review!
Attachment 373559 [details] pushed as cbf8115 - gstreamer recipes: Centralize the source download logic