After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 797063 - h265parse: Add split-field interlacing to h265parse & interlace elements
h265parse: Add split-field interlacing to h265parse & interlace elements
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
unspecified
Other All
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-08-31 17:12 UTC by Zeeshan Ali
Modified: 2018-11-03 14:30 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
h265parse: Handle interlaced video (2.68 KB, patch)
2018-08-31 17:13 UTC, Zeeshan Ali
none Details | Review
h265parse: Derive src fps from vui_time_scale & vui_num_units_in_tick (1.93 KB, patch)
2018-08-31 17:13 UTC, Zeeshan Ali
none Details | Review
h265parse: Set duration on buffers (1.36 KB, patch)
2018-08-31 17:13 UTC, Zeeshan Ali
none Details | Review
interlace: add support for NV12_10LE32, NV16 and NV16_10LE32 formats (1.49 KB, patch)
2018-08-31 17:13 UTC, Zeeshan Ali
none Details | Review
interlace: Add support for 'alternate' format (8.09 KB, patch)
2018-08-31 17:13 UTC, Zeeshan Ali
none Details | Review

Description Zeeshan Ali 2018-08-31 17:12:57 UTC
These patches add split-field (alternate) interlacing support to h265parse and interlace elements.

These patches are not yet ready to be merged as the caps lack the needed feature, which will be added soon. The point of submitting them already was to already get opinions/suggestions on the main changes.

Also I'm not entirely sure if the (short-cut) approach I took for interlace is what we would want. Suggestions welcome.
Comment 1 Zeeshan Ali 2018-08-31 17:13:03 UTC
Created attachment 373525 [details] [review]
h265parse: Handle interlaced video

For interlaced video:

* set the interlace mode in the src caps
* double the height from SPS in the caps.
* set field latency, instead of frame latency.
Comment 2 Zeeshan Ali 2018-08-31 17:13:14 UTC
Created attachment 373526 [details] [review]
h265parse: Derive src fps from vui_time_scale & vui_num_units_in_tick
Comment 3 Zeeshan Ali 2018-08-31 17:13:22 UTC
Created attachment 373527 [details] [review]
h265parse: Set duration on buffers

Based on the framerate.
Comment 4 Zeeshan Ali 2018-08-31 17:13:31 UTC
Created attachment 373528 [details] [review]
interlace: add support for NV12_10LE32, NV16 and NV16_10LE32 formats

The interlacing code uses the GST_VIDEO_FRAME_PLANE API and is generic
enough to work with those planar formats as well.
Comment 5 Zeeshan Ali 2018-08-31 17:13:41 UTC
Created attachment 373529 [details] [review]
interlace: Add support for 'alternate' format

In this format, each buffer contains only 1 of the 2 fields of the video
in alternating form.
Comment 6 GStreamer system administrator 2018-11-03 14:30:50 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/778.