GNOME Bugzilla – Bug 797062
v4l2: Add split-field interlacing to v4l2src & deinterlace
Last modified: 2018-11-03 15:33:01 UTC
These patches add split-field (alternate) interlacing support to v4l2src and deinterlace elements. These patches are not yet ready to be merged as the caps lack the needed feature, which will be added soon. The point of submitting them already was to already get opinions/suggestions on the main changes. Also I'm not entirely sure if the (short-cut) approach I took for deinterlace is what we would want. Suggestions welcome.
Created attachment 373519 [details] [review] v4l2: Make use of gst_video_interlace_mode_to_string() Instead of a custom map to translate the interlace modes to strings, let's make use of the base API provided.
Created attachment 373520 [details] [review] v4l2: Avoid code duplication The function gst_v4l2_object_add_interlace_mode() has repeating code so it's best use a loop instead. That will make it easy and simple to add additional interlace modes in a following patch. Co-author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Created attachment 373521 [details] [review] v4l2: Add split-field interlacing support Co-author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Created attachment 373522 [details] [review] v4l2: Double buffer pool's min size for ALTERNATE interlacing Since each of the two fields go into their own buffer in this mode, we need twice the amount of buffers.
Created attachment 373523 [details] [review] Remove dead code related to child proxy This code has been disabled for at least 2 years and as the comment says, there doesn't seem to be any use of this code since the underlying deinterlacing method classes don't provide any properties to set.
Created attachment 373524 [details] [review] deinterlace: Handle ALTERNATE interlacing mode For this mode, simply combine the two consecutive fields.
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/issues/504.