After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 797054 - h264parse: Critical warning when parsing framerate from youtube-dl
h264parse: Critical warning when parsing framerate from youtube-dl
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.14.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-08-30 16:43 UTC by Philippe Normand
Modified: 2018-08-31 14:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.53 KB, patch)
2018-08-30 16:48 UTC, Philippe Normand 		committed Details | Review

Description Philippe Normand 2018-08-30 16:43:20 UTC 
gst_util_uint64_scale_int() is called with its last argument being a guint. :)

youtube-dl "https://vimeo.com/280481143" -o - | G_DEBUG=fatal_criticals  gst-play-1.0 fd://0

(gdb) bt

+ Trace 238681

  • #0 0x00007f2251a2ac41 in
  • #1 g_logv
  • #2 g_log
  • #3 _gst_util_uint64_scale_int
    at ../subprojects/gstreamer/gst/gstutils.c line 680
  • #4 gst_base_parse_push_frame
    at ../subprojects/gstreamer/libs/gst/base/gstbaseparse.c line 2553
  • #5 gst_base_parse_finish_frame
    at ../subprojects/gstreamer/libs/gst/base/gstbaseparse.c line 2707
  • #6 gst_h264_parse_handle_frame
    at ../subprojects/gst-plugins-bad/gst/videoparsers/gsth264parse.c line 1276
  • #7 gst_base_parse_handle_buffer
    at ../subprojects/gstreamer/libs/gst/base/gstbaseparse.c line 2206
  • #8 gst_base_parse_chain
    at ../subprojects/gstreamer/libs/gst/base/gstbaseparse.c line 3230
  • #9 gst_pad_chain_data_unchecked
    at ../subprojects/gstreamer/gst/gstpad.c line 4322
  • #10 gst_pad_push_data
    at ../subprojects/gstreamer/gst/gstpad.c line 4578
  • #11 gst_pad_push
    at ../subprojects/gstreamer/gst/gstpad.c line 4697
  • #12 gst_single_queue_push_one
    at ../subprojects/gstreamer/plugins/elements/gstmultiqueue.c line 1643
  • #13 gst_multi_queue_loop
    at ../subprojects/gstreamer/plugins/elements/gstmultiqueue.c line 1963
  • #14 gst_task_func
    at ../subprojects/gstreamer/gst/gsttask.c line 328
  • #15 0x00007f2251a4d7d0 in
  • #16 0x00007f2251a4ce05 in
  • #17 start_thread
    at pthread_create.c line 463
  • #18 clone
    at ../sysdeps/unix/sysv/linux/x86_64/clone.S line 95 






Comment 1


Philippe Normand





          2018-08-30 16:48:25 UTC
        



Created attachment 373505 [details] [review]
patch






Comment 2


Thibault Saunier





          2018-08-31 14:00:16 UTC
        



Review of attachment 373505 [details] [review]:

Makes sense.






Comment 3


Thibault Saunier





          2018-08-31 14:00:35 UTC
        



Review of attachment 373505 [details] [review]:

Accepted, not commited.






Comment 4


Philippe Normand





          2018-08-31 14:50:38 UTC
        



Comment on attachment 373505 [details] [review]
patch

Pushed in master, will cherry-pick to 1.14 as well!

commit d7c87910c297c200151127e2fdc081e437923e82 (HEAD -> master, origin/master, origin/HEAD)
Author: Philippe Normand <philn@igalia.com>
Date:   Thu Aug 30 17:44:07 2018 +0100

    baseparse: avg_bitrate calculation critical warning fix
    
    The avg_bitrate is an unsigned int, so the gst_util_uin64_scale() function can't
    be used for it, as it expects signed integers for the fraction parts arguments.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=797054