After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 797041 - Licensing fixes for gst-libav-1.0.recipe
Licensing fixes for gst-libav-1.0.recipe
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: cerbero
unspecified
Other All
: Normal normal
: 1.15.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-08-29 06:05 UTC by Nirbheek Chauhan
Modified: 2018-08-29 23:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gst-libav-1.0.recipe: Fix license configure option (1.62 KB, patch)
2018-08-29 06:05 UTC, Nirbheek Chauhan 		committed Details | Review
gst-libav-1.0.recipe: Make licensing explicit (3.05 KB, patch)
2018-08-29 06:05 UTC, Nirbheek Chauhan 		committed Details | Review

Description Nirbheek Chauhan 2018-08-29 06:05:17 UTC 
The gst-libav option was changed after 1.5.2, and we forgot to change it here.
Comment 1 Nirbheek Chauhan 2018-08-29 06:05:23 UTC 
Created attachment 373492 [details] [review]
gst-libav-1.0.recipe: Fix license configure option

The option is --disable-gpl not --enable-lgpl, and the default is
--enable-gpl, which causes the plugin to incorrectly report its
license as GPLv2.

Thankfully, ffmpeg's default is --disable-gpl, so the only issue this
caused was the plugin misreporting its license. Verified by checking
ffmpeg configure output:

    Configuring included Libav instance with args

    ...

    License: LGPL version 2.1 or later

The default for ffmpeg is also --disable-nonfree + --disable-version3
so the license specified in the recipe is correct.
Comment 2 Nirbheek Chauhan 2018-08-29 06:05:30 UTC 
Created attachment 373493 [details] [review]
gst-libav-1.0.recipe: Make licensing explicit
Comment 3 Nirbheek Chauhan 2018-08-29 06:07:45 UTC 
(In reply to Nirbheek Chauhan from comment #1)
> Created attachment 373492 [details] [review] [review]
> gst-libav-1.0.recipe: Fix license configure option
> 
> The option is --disable-gpl not --enable-lgpl, and the default is
> --enable-gpl, which causes the plugin to incorrectly report its
> license as GPLv2.
> 

Hum, this part of the commit message is wrong. Will fix that before pushing.
Comment 4 Nirbheek Chauhan 2018-08-29 23:43:44 UTC 
Attachment 373492 [details] pushed as 72ffa91 - gst-libav-1.0.recipe: Fix license configure option
Attachment 373493 [details] pushed as e995ea7 - gst-libav-1.0.recipe: Make licensing explicit