After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 797038 - omxvideoenc: pause component when flushing
omxvideoenc: pause component when flushing
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-omx
git master
Other Linux
: Normal normal
: 1.15.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-08-28 13:51 UTC by Guillaume Desmottes
Modified: 2018-08-28 14:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
omxvideoenc: pause component when flushing (1.87 KB, patch)
2018-08-28 13:52 UTC, Guillaume Desmottes 		committed Details | Review

Description Guillaume Desmottes 2018-08-28 13:51:58 UTC 
.
Comment 1 Guillaume Desmottes 2018-08-28 13:52:18 UTC 
Created attachment 373484 [details] [review]
omxvideoenc: pause component when flushing

As stated in the spec ("6.1.3 Seek Event Sequence") we should pause
before flushing.
We were pausing the decoder but not the encoder so I just aligned the
two code paths.
Comment 2 Nicolas Dufresne (ndufresne) 2018-08-28 14:19:59 UTC 
Review of attachment 373484 [details] [review]:

Lgtm.
Comment 3 Guillaume Desmottes 2018-08-28 14:23:24 UTC 
Attachment 373484 [details] pushed as 626a481 - omxvideoenc: pause component when flushing