After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 797035 - subparse: Remove checking text buffer length
subparse: Remove checking text buffer length
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-08-28 06:55 UTC by Hosang Lee
Modified: 2018-11-03 12:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
subparse: Remove checking text buffer length (1.16 KB, patch)
2018-08-28 06:55 UTC, Hosang Lee 		none Details | Review
subparse: Remove checking text buffer length (1.16 KB, patch)
2018-08-28 06:58 UTC, Hosang Lee 		none Details | Review
Lower text buffer length threshold when detecting format (1.12 KB, patch)
2018-08-28 23:36 UTC, Hosang Lee 		none Details | Review

Description Hosang Lee 2018-08-28 06:55:54 UTC 
Created attachment 373471 [details] [review]
subparse: Remove checking text buffer length

It is possible for subtitle files to have a string length less than 30.
WebVTT for example may contain only the 'WEBVTT' string in the file.
As an example in hls streams, since WEBVTT files can be segemented
like video/audio, some subtitle segements may only contain just the
header string.
Returning null here results to the pads not being exposed properly.
Comment 1 Hosang Lee 2018-08-28 06:58:53 UTC 
Created attachment 373472 [details] [review]
subparse: Remove checking text buffer length
Comment 2 Edward Hervey 2018-08-28 09:15:27 UTC 
Why not keep the check, but bring it down to 6 ?
Comment 3 Hosang Lee 2018-08-28 23:36:04 UTC 
Created attachment 373488 [details] [review]
Lower text buffer length threshold when detecting format

Thanks for the review.
Brought it down to 6.
Comment 4 GStreamer system administrator 2018-11-03 12:09:42 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/480.