After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 797011 - uninstalled: use usercustomize, not sitecustomize
uninstalled: use usercustomize, not sitecustomize
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-build
git master
Other Linux
: Normal normal
: 1.15.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-08-22 16:16 UTC by Martin Kelly
Modified: 2018-09-13 15:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (1.88 KB, patch)
2018-08-22 16:16 UTC, Martin Kelly
none Details | Review
patch (1.83 KB, patch)
2018-08-22 16:18 UTC, Martin Kelly
accepted-commit_now Details | Review

Description Martin Kelly 2018-08-22 16:16:57 UTC
Created attachment 373427 [details] [review]
patch

Currently, gst-uninstalled is using sitecustomize.py for adding gi
override tweaks. However, if the standard Python libraries come before
this file in sys.path, then sitecustomize.py will never be run because
the "import sitecustomize" done in site.py will use the standard Python
libraries instead. This can be seen by running "import sitecustomize;
print(sitecustomize.__file__)" inside the uninstalled environment, as
well as by checking gi.override.__path__ and seeing that the tweaks are
missing (and the overrides are misbehaving).

Switch to using usercustomize.py, which has no match in the standard
libraries and thus will be correctly imported.
Comment 1 Martin Kelly 2018-08-22 16:18:45 UTC
Created attachment 373428 [details] [review]
patch

Removed Signed-off-by, which is not used by this repo.
Comment 2 Martin Kelly 2018-09-12 18:14:54 UTC
(ping)
Comment 3 Philippe Normand 2018-09-13 09:44:32 UTC
Review of attachment 373428 [details] [review]:

LGTM :)
Comment 4 Thibault Saunier 2018-09-13 10:06:08 UTC
Sorry I had that one stack on my local branch and forgot to push :-)

Thanks.
Comment 5 Martin Kelly 2018-09-13 15:15:52 UTC
No problem and thank you!