GNOME Bugzilla – Bug 796969
flvmux: Don't set DELTA_UNIT flag on audio buffer for non-audio only case
Last modified: 2018-11-03 15:32:37 UTC
Unset DELTA_UNIT on audio buffer could make sense, however, if downstream is waiting keyframe, the downstream could be confused, That is, downstream cannot know which buffer is a video keyframe, because flvmux unset DELTA_UNIT flag on both keyframe and audio buffer. Since the original intention of the code was "mark the buffer if it's an audio buffer and there's also video being muxed or it's a video interframe", rollback to previous behavior before the commit 8b814f6.
Created attachment 373349 [details] [review] flvmux: Don't set DELTA_UNIT flag on audio buffer for non-audio only case
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/issues/500.