After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 796969 - flvmux: Don't set DELTA_UNIT flag on audio buffer for non-audio only case
flvmux: Don't set DELTA_UNIT flag on audio buffer for non-audio only case
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-08-16 05:30 UTC by Seungha Yang
Modified: 2018-11-03 15:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
flvmux: Don't set DELTA_UNIT flag on audio buffer for non-audio only case (1.42 KB, patch)
2018-08-16 05:31 UTC, Seungha Yang
none Details | Review

Description Seungha Yang 2018-08-16 05:30:24 UTC
Unset DELTA_UNIT on audio buffer could make sense, however,
if downstream is waiting keyframe, the downstream could be confused,
That is, downstream cannot know which buffer is a video keyframe,
because flvmux unset DELTA_UNIT flag on both keyframe and audio buffer.

Since the original intention of the code was
"mark the buffer if it's an audio buffer and there's also
video being muxed or it's a video interframe", rollback to previous
behavior before the commit 8b814f6.
Comment 1 Seungha Yang 2018-08-16 05:31:08 UTC
Created attachment 373349 [details] [review]
flvmux: Don't set DELTA_UNIT flag on audio buffer for non-audio only case
Comment 2 GStreamer system administrator 2018-11-03 15:32:37 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/issues/500.