After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 796906 - avwait: Don't wait if audio_running_time_to_wait_for is NONE
avwait: Don't wait if audio_running_time_to_wait_for is NONE
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
unspecified
Other All
: Normal normal
: 1.15.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-08-01 12:51 UTC by Vivia Nikolaidou
Modified: 2018-08-01 17:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
avwait: Don't wait if audio_running_time_to_wait_for is NONE (2.47 KB, patch)
2018-08-01 12:51 UTC, Vivia Nikolaidou 		committed Details | Review

Description Vivia Nikolaidou 2018-08-01 12:51:33 UTC 
See commit message
Comment 1 Vivia Nikolaidou 2018-08-01 12:51:37 UTC 
Created attachment 373239 [details] [review]
avwait: Don't wait if audio_running_time_to_wait_for is NONE

The case is properly handled a few lines below by dropping the buffer.
We shouldn't perpetually block the audio chain function until the
target-timecode is reached.
Comment 2 Vivia Nikolaidou 2018-08-01 17:21:55 UTC 
Review of attachment 373239 [details] [review]:

commit 8ede252a8a3da38a63e1ce8a27a29313f29efc16 (HEAD -> master, dev/master)
Author: Vivia Nikolaidou <vivia@ahiru.eu>
Date:   Wed Aug 1 15:11:09 2018 +0300

    avwait: Don't wait if audio_running_time_to_wait_for is NONE

    The case is properly handled a few lines below by dropping the buffer.
    We shouldn't perpetually block the audio chain function until the
    target-timecode is reached.

    https://bugzilla.gnome.org/show_bug.cgi?id=796906