After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 796886 - rtspsrc: consistently send TEARDOWN.
rtspsrc: consistently send TEARDOWN.
Status: RESOLVED DUPLICATE of bug 751994
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-07-27 14:03 UTC by Niels De Graef
Modified: 2018-07-28 13:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
rtspsrc: consistently send TEARDOWN. (1.84 KB, patch)
2018-07-27 14:03 UTC, Niels De Graef 		none Details | Review

Description Niels De Graef 2018-07-27 14:03:06 UTC 
Created attachment 373189 [details] [review]
rtspsrc: consistently send TEARDOWN.

When going from PLAYING to NULL with a source that doesn't support the
PAUSE command, the CMD_WAIT command interrupts the CMD_CLOSE, cancelling
the TEARDOWN. Even more, the CMD_WAIT command that is sent when
interrupting the loop will set the pending_cmd to CMD_LOOP, making sure
that the next command might still flush the GstRtspConnection,
effectively cancelling the TEARDOWN.


This also fixes the case of gst-play that was mentioned in bug 748360, comment 6
Comment 1 Jan Schmidt 2018-07-28 13:06:42 UTC 
This achieves the same thing as my patch for bug 751994 - it avoids shutting down the background thread until the command has been processed, but without the timeout I added, it could block indefinitely waiting for that to happen so I think it's better the keep the timeout.

Sorry for the overlap and duplicated effort, but thanks for the patch!

*** This bug has been marked as a duplicate of bug 751994 ***
Comment 2 Jan Schmidt 2018-07-28 13:07:24 UTC 
(please continue on the other bug if you disagree)