After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 796877 - rtpgstpay: Add support for force-keyunit events
rtpgstpay: Add support for force-keyunit events
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other All
: Normal enhancement
: 1.14.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-07-26 13:44 UTC by Sebastian Dröge (slomo)
Modified: 2018-08-02 08:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
rtpgstpay: Add support for force-keyunit events (4.12 KB, patch)
2018-07-26 13:44 UTC, Sebastian Dröge (slomo) 		none Details | Review
rtpgstpay: Add support for force-keyunit events (4.18 KB, patch)
2018-07-26 13:54 UTC, Sebastian Dröge (slomo) 		committed Details | Review

Description Sebastian Dröge (slomo) 2018-07-26 13:44:16 UTC 
See commit message
Comment 1 Sebastian Dröge (slomo) 2018-07-26 13:44:23 UTC 
Created attachment 373171 [details] [review]
rtpgstpay: Add support for force-keyunit events

This triggers immediate re-sending of the configuration data in-band.
Comment 2 Tim-Philipp Müller 2018-07-26 13:48:28 UTC 
Comment on attachment 373171 [details] [review]
rtpgstpay: Add support for force-keyunit events

Looks reasonable, but should we be using g_atomic_int_*() here seeing that the source event might be coming from a different thread than handle_buffer() runs in?
Comment 3 Sebastian Dröge (slomo) 2018-07-26 13:54:45 UTC 
Created attachment 373172 [details] [review]
rtpgstpay: Add support for force-keyunit events

This triggers immediate re-sending of the configuration data in-band.
Comment 4 Sebastian Dröge (slomo) 2018-07-26 13:55:06 UTC 
Done, shouldn't matter in practice but is nicer indeed.
Comment 5 Sebastian Dröge (slomo) 2018-07-26 14:08:42 UTC 
Attachment 373172 [details] pushed as 9a80cdb - rtpgstpay: Add support for force-keyunit events
Comment 6 Olivier Crête 2018-07-26 15:50:43 UTC 
Shouldn't you wait for the force-keyunit even to come back from upstream, either from the encoder or the parser?
Comment 7 Sebastian Dröge (slomo) 2018-07-27 07:48:26 UTC 
Why? Having the caps is useful by itself already without any actual keyframe coming later, and if an actual keyframe comes later then that's just handled as usual.

And the event would never come back in many cases, e.g. if you just have "filesrc ! mpegaudioparse ! rtpgstpay ! ...", so those cases wouldn't work then.