GNOME Bugzilla – Bug 796826
videodecoder: print warning if frame drops due to QoS
Last modified: 2018-07-18 19:21:33 UTC
Print a warning message if frame drops due to QoS.
Created attachment 373079 [details] [review] videodecoder: print warning if dropping frame due to QoS
basesink for example is also not making this a warning, it's only logging it with debug level.
Comment on attachment 373079 [details] [review] videodecoder: print warning if dropping frame due to QoS It's something that's fairly normal/expected in most real-world use cases, so don't know if it should be a warning.
We should post QoS message, see: https://bugzilla.gnome.org/show_bug.cgi?id=796762 *** This bug has been marked as a duplicate of bug 796762 ***
(In reply to Tim-Philipp Müller from comment #3) > Comment on attachment 373079 [details] [review] [review] > videodecoder: print warning if dropping frame due to QoS > > It's something that's fairly normal/expected in most real-world use cases, > so don't know if it should be a warning. I was debugging the issue here :https://bugzilla.gnome.org/show_bug.cgi?id=796521 . Adding a msdkvpp just after the decoder caused dropping frames in decoder, and didn't generate any warning. I think, we should generate a warning if there is a drop frame irrespective of the root cause of dropping.
No, drops should generate application messages, not warning.
Also, in master we just merged code that introduce processing-deadline on basesink, which is suppose to address these issues.