After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 796822 - glupload: Only offer DMABuf caps feature if using EGL
glupload: Only offer DMABuf caps feature if using EGL
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other All
: Normal normal
: 1.15.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 797005 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2018-07-17 15:55 UTC by Nicolas Dufresne (ndufresne)
Modified: 2018-08-22 10:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
glupload: Only offer DMABuf caps feature if using EGL (1.19 KB, patch)
2018-07-17 15:55 UTC, Nicolas Dufresne (ndufresne) 		none Details | Review
glupload: Only offer DMABuf caps feature if using EGL (1.22 KB, patch)
2018-07-17 16:19 UTC, Nicolas Dufresne (ndufresne) 		committed Details | Review

Description Nicolas Dufresne (ndufresne) 2018-07-17 15:55:32 UTC 
This is patch is not yet correct, caused assertion as apparently the
transform function can be called with NULL context. I was also wondering if
these calls are save from outside the GL Thread. Attaching for help.
Comment 1 Nicolas Dufresne (ndufresne) 2018-07-17 15:55:36 UTC 
Created attachment 373077 [details] [review]
glupload: Only offer DMABuf caps feature if using EGL

This was miss-leading VAAPI which was not forcing linear back buffers,
would still export DMABuf. That caused bad rendering as the buffers are
tiled and most likely compressed.
Comment 2 Nicolas Dufresne (ndufresne) 2018-07-17 16:19:50 UTC 
Created attachment 373078 [details] [review]
glupload: Only offer DMABuf caps feature if using EGL

This was miss-leading VAAPI which was not forcing linear back buffers,
would still export DMABuf. That caused bad rendering as the buffers are
tiled and most likely compressed.
Comment 3 Matthew Waters (ystreet00) 2018-07-18 03:46:17 UTC 
Review of attachment 373078 [details] [review]:

Looks good
Comment 4 Nicolas Dufresne (ndufresne) 2018-07-18 13:04:49 UTC 
Attachment 373078 [details] pushed as 63cf6b4 - glupload: Only offer DMABuf caps feature if using EGL
Comment 5 Víctor Manuel Jáquez Leal 2018-08-22 10:29:52 UTC 
*** Bug 797005 has been marked as a duplicate of this bug. ***