After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 796798 - build: Use new meson 'feature' option and dictionnary
build: Use new meson 'feature' option and dictionnary
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-build
unspecified
Other All
: Normal normal
: 1.15.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-07-12 14:16 UTC by Thibault Saunier
Modified: 2018-07-12 16:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use new 'feature' option and dictionnary (9.45 KB, patch)
2018-07-12 14:16 UTC, Thibault Saunier 		none Details | Review
Use new 'feature' option and dictionnary (9.15 KB, patch)
2018-07-12 15:03 UTC, Thibault Saunier 		committed Details | Review

Description Thibault Saunier 2018-07-12 14:16:03 UTC 
.
Comment 1 Thibault Saunier 2018-07-12 14:16:07 UTC 
Created attachment 373007 [details] [review]
Use new 'feature' option and dictionnary

Simplifying the build definition, making its options more flexible and
it is now simpler to read.
Comment 2 Mathieu Duponchelle 2018-07-12 14:28:09 UTC 
Review of attachment 373007 [details] [review]:

::: meson.build
@@ -145,3 +107,6 @@
-message('Building subprojects: ' + ', '.join(subprojects))
-foreach subproj: subprojects
-    subproject(subproj, version: gst_version)
+subprojects_names = []
+foreach project_name, build_infos: subprojects
+    build = false
... 3 more ...

I think you could do:

elif get_option(build_infos.get('option')).auto()
Comment 3 Thibault Saunier 2018-07-12 15:03:17 UTC 
Created attachment 373008 [details] [review]
Use new 'feature' option and dictionnary

Simplifying the build definition, making its options more flexible and
it is now simpler to read.
Comment 4 Mathieu Duponchelle 2018-07-12 15:16:27 UTC 
Review of attachment 373008 [details] [review]:

Nice :D
Comment 5 Thibault Saunier 2018-07-12 16:25:01 UTC 
Attachment 373008 [details] pushed as 3d47163 - Use new 'feature' option and dictionnary