Created attachment 372999 [details] [review]
meson: build nvdec

Review of attachment 372999 [details] [review]:

::: meson.build
@@ +478,3 @@
 endif
 
+# CUDA

This should all go to the nvdec directory.

@@ +483,3 @@
+
+have_nvdec = false
+if cuda_prefix != ''

Should we really support that case if there is a `.pc` file?

(In reply to Thibault Saunier from comment #2)
> Review of attachment 372999 [details] [review] [review]:
> 
> ::: meson.build
> @@ +478,3 @@
>  endif
>  
> +# CUDA
> 
> This should all go to the nvdec directory.

I would move it to the sys/ directory/ It's also useful for nvenc.

> @@ +483,3 @@
> +
> +have_nvdec = false
> +if cuda_prefix != ''
> 
> Should we really support that case if there is a `.pc` file?

There generally isn't .pc files unless distributions patch them in.

(In reply to Thibault Saunier from comment #2)
> +# CUDA
> 
> This should all go to the nvdec directory.
> 

I copied that part from configure.ac, the cuda checks are also needed by nvenc, which I didn't port, but these checks will need to be shared

> @@ +483,3 @@
> +
> +have_nvdec = false
> +if cuda_prefix != ''
> 
> Should we really support that case if there is a `.pc` file?

I don't know, I can remove that bit :)

-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/750.