After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 796749 - omxvideoenc: include vertical padding in nFilledLen when copying
omxvideoenc: include vertical padding in nFilledLen when copying
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-omx
unspecified
Other Linux
: Normal normal
: 1.15.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-07-05 14:07 UTC by Guillaume Desmottes
Modified: 2018-07-13 12:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
omxvideoenc: include vertical padding in nFilledLen when copying (2.28 KB, patch)
2018-07-05 14:08 UTC, Guillaume Desmottes 		committed Details | Review
omxvideoenc: fix vertical padding in NV16 formats (2.90 KB, patch)
2018-07-12 12:47 UTC, Guillaume Desmottes 		none Details | Review
omxvideoenc: fix vertical padding in NV16 formats (2.76 KB, patch)
2018-07-13 07:54 UTC, Guillaume Desmottes 		committed Details | Review

Description Guillaume Desmottes 2018-07-05 14:07:40 UTC 
.
Comment 1 Guillaume Desmottes 2018-07-05 14:08:10 UTC 
Created attachment 372951 [details] [review]
omxvideoenc: include vertical padding in nFilledLen when copying

According to the OMX spec (3.1.3.7.1) nFilledLen is meant to include any
padding. We use to include the horizontal one (stride) but not the
vertical one if nSliceHeight is bigger than the actual height.

The calculated nFilledLen was wrong as it didn't include the padding
between planes.
Comment 2 Guillaume Desmottes 2018-07-05 14:49:44 UTC 
Tested on zynq and rpi.
On the rpi, a 1920x1080 stream has 1088 as nSliceHeight. The pi OMX is happy with either nFilledLen containing the padding or not (tested with both NV12 and I420).
Comment 3 Nicolas Dufresne (ndufresne) 2018-07-05 14:52:08 UTC 
Review of attachment 372951 [details] [review]:

.
Comment 4 Guillaume Desmottes 2018-07-05 14:54:28 UTC 
Attachment 372951 [details] pushed as 1e9d7a6 - omxvideoenc: include vertical padding in nFilledLen when copying
Comment 5 Guillaume Desmottes 2018-07-12 12:47:36 UTC 
re-opening as I found a bug in my patch.
Comment 6 Guillaume Desmottes 2018-07-12 12:47:52 UTC 
Created attachment 373006 [details] [review]
omxvideoenc: fix vertical padding in NV16 formats

My previous patch to calculate the vertical padding was always halfing
the height of the chroma plane which is incorrect for NV16 formats.
Comment 7 Guillaume Desmottes 2018-07-13 07:54:54 UTC 
Created attachment 373047 [details] [review]
omxvideoenc: fix vertical padding in NV16 formats

My previous patch to calculate the vertical padding was always halfing
the height of the chroma plane which is incorrect for NV16 formats.
Comment 8 Nicolas Dufresne (ndufresne) 2018-07-13 12:49:00 UTC 
Review of attachment 373047 [details] [review]:

Looks good.
Comment 9 Guillaume Desmottes 2018-07-13 12:51:50 UTC 
Attachment 373047 [details] pushed as a863893 - omxvideoenc: fix vertical padding in NV16 formats