After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 796695 - Pango-CRITICAL with subtitle markup error
Pango-CRITICAL with subtitle markup error
Status: RESOLVED DUPLICATE of bug 795891
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other Windows
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-06-27 15:34 UTC by Jiří Engelthaler
Modified: 2018-07-02 10:26 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Jiří Engelthaler 2018-06-27 15:34:39 UTC
This file https://mega.nz/#!ozQSkCKL!vJT9OJ1VDo-CBcx4Yq3foFCJKhUTGXyozHKnDCcWFrw with markup error in subtitles produces 

Pango-CRITICAL **: pango_attr_list_filter: assertion 'list != NULL' failed

On system with enable_debug=no in pango the program crashes with segfault.
Comment 1 Philippe Normand 2018-06-27 18:00:44 UTC
Looks like a dupe of https://bugzilla.gnome.org/show_bug.cgi?id=795891
Comment 2 Philippe Normand 2018-06-27 18:02:37 UTC
In addition to that warning I also get this one:

 Pango-WARNING **: 19:01:38.891: pango_layout_set_markup_with_accel: Error on line 1 char 69: Element 'markup' was closed, but the currently open element is 'i'
Comment 3 Jiří Engelthaler 2018-06-27 19:50:06 UTC
(In reply to Philippe Normand from comment #2)
> In addition to that warning I also get this one:
> 
>  Pango-WARNING **: 19:01:38.891: pango_layout_set_markup_with_accel: Error
> on line 1 char 69: Element 'markup' was closed, but the currently open
> element is 'i'

You are right. There is a error in subtitle markup. There is a text
<i>..Jihozápadní vítr, občasné přehánky...<i>

Instead of </i> there is <i> on the end. With this error, GStreamer segfaults with pango configured with --enable_debug=no
Comment 4 Sebastian Dröge (slomo) 2018-06-29 05:40:38 UTC
User input should never cause criticals or crashes, so we need to do some validation here.
Comment 5 Philippe Normand 2018-06-30 12:45:03 UTC
The patches in https://bugzilla.gnome.org/show_bug.cgi?id=795891 fix the issue for me... If you'd like to test them as well :)
Comment 6 Sebastian Dröge (slomo) 2018-07-02 10:26:31 UTC
Thanks for taking the time to report this.
This particular bug has already been reported into our bug tracking system, but please feel free to report any further bugs you find.

*** This bug has been marked as a duplicate of bug 795891 ***