After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 796678 - alsasink: pause/resume
alsasink: pause/resume
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-06-26 09:48 UTC by Axel Mårtensson
Modified: 2018-11-03 12:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
alsasink: pause/resume (6.25 KB, patch)
2018-06-26 09:48 UTC, Axel Mårtensson
none Details | Review
alsasink: pause/resume (6.30 KB, patch)
2018-06-27 08:42 UTC, Axel Mårtensson
none Details | Review

Description Axel Mårtensson 2018-06-26 09:48:47 UTC
Created attachment 372823 [details] [review]
alsasink: pause/resume

alsasink have no possibility to distinguish between a pause and stop. 

This patch adds the functionality to pause, stop and resume for the alsasink.

Pause and resume takes use of snd_pcm_pause() to handle the pause/resume capabilities.

The following patch is required to expose the pause, resume and stop vmethod to alsasink: https://bugzilla.gnome.org/show_bug.cgi?id=788361
Comment 1 Nicolas Dufresne (ndufresne) 2018-06-26 13:06:05 UTC
Looks like a duplicate of https://bugzilla.gnome.org/show_bug.cgi?id=750694 can you confirm if your patch fixes this issue ?
Comment 2 Axel Mårtensson 2018-06-27 08:42:04 UTC
Created attachment 372843 [details] [review]
alsasink: pause/resume

Fixed a bug that caused the alsasink to get stuck if the hardware did not support snd_pcm_pause().
Comment 3 Axel Mårtensson 2018-06-27 08:55:37 UTC
Hi, Nicolas

I performed a test using gst-play-1.0 --audiosink="alsasink provide-clock=0" audio-file as described in https://bugzilla.gnome.org/show_bug.cgi?id=750694

My initial thoughts is that with the patch, the gap is less or even gone compared to without the patch. 

The test was done quickly and I would not draw a conclusion before some more testing is done. You are welcome to apply the patches and test for yourself. 

The patches to expose vmethods to child sinks can be found here https://bugzilla.gnome.org/show_bug.cgi?id=788361

Best regards,
Axel
Comment 4 Robert Rosengren 2018-10-19 09:28:23 UTC
Hi, 
following up on this issue - any chance for input?
BR, Robert
Comment 5 GStreamer system administrator 2018-11-03 12:08:15 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/465.