GNOME Bugzilla – Bug 796676
playbin3: take only playsink locking in a same thread without taking playbin3 locking
Last modified: 2018-11-03 12:08:11 UTC
Dear All I have observed deadlock problem in our target platform with gst v1.14. I think the deadlock is happened between getting property 'PROP_SUBTITLE_ENCODING' and activate_chain (). I think it makes sense not to taking playbin3 locking with playsink locking in a same thread in gst_play_sink_get_subtitle_encoding (). Thanks.
Created attachment 372821 [details] [review] playbin3: don't take duplicate locking in between playbin3 and playsink
Comment on attachment 372821 [details] [review] playbin3: don't take duplicate locking in between playbin3 and playsink This does not apply anymore to GIT master, the locks are in a different function. Can you update the patch?
(In reply to Sebastian Dröge (slomo) from comment #2) > Comment on attachment 372821 [details] [review] [review] > playbin3: don't take duplicate locking in between playbin3 and playsink > > This does not apply anymore to GIT master, the locks are in a different > function. Can you update the patch? Sorry, I don't understand what you mean. I think GST_PLAY_BIN3_LOCK is not needed. Because, there is GST_PLAY_SINK_LOCK in gst_play_sink_get_subtitle_encoding () function likes PROP_VOLUME, PROP_MUTE and PROP_SAMPLE. Can you explain in detail what you mean ? Thanks.
The patch does not apply to git master anymore because the lock was moved to another function. The lock can go away, that's correct, but you have to update the patch to remove the locking from a different place.
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/464.