After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 796672 - v4l2object: use S_SELECTION instead of S_CROP in gst_v4l2_object_set_crop
v4l2object: use S_SELECTION instead of S_CROP in gst_v4l2_object_set_crop
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 1.14.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-06-25 16:52 UTC by Philipp Zabel
Modified: 2018-06-27 21:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
v4l2object: use S_SELECTION instead of S_CROP in gst_v4l2_object_set_crop (2.72 KB, patch)
2018-06-25 16:52 UTC, Philipp Zabel 		committed Details | Review

Description Philipp Zabel 2018-06-25 16:52:37 UTC 
Created attachment 372818 [details] [review]
v4l2object: use S_SELECTION instead of S_CROP in gst_v4l2_object_set_crop

The S_CROP call doesn't work on mem2mem output queues. Use the
S_SELECTION call to set the crop rectangle and only fall back to
S_CROP for ancient kernels.
This will allow v4l2videoenc to set the coded size on the output
queue via S_FMT and then set the visible size via the crop rectangle,
as required by the V4L2 codec API.
Comment 1 Nicolas Dufresne (ndufresne) 2018-06-27 20:32:58 UTC 
Attachment 372818 [details] pushed as 32fa1e7 - v4l2object: use S_SELECTION instead of S_CROP in gst_v4l2_object_set_crop