After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 796639 - souphttpsrc: Protect input stream with lock
souphttpsrc: Protect input stream with lock
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other All
: Normal normal
: 1.14.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-06-20 08:05 UTC by Edward Hervey
Modified: 2018-07-18 14:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
souphttpsrc: Protect input stream with lock (1.51 KB, patch)
2018-06-20 08:05 UTC, Edward Hervey 		committed Details | Review

Description Edward Hervey 2018-06-20 08:05:32 UTC 
See commit
Comment 1 Edward Hervey 2018-06-20 08:05:38 UTC 
Created attachment 372733 [details] [review]
souphttpsrc: Protect input stream with lock

This was the last remaining place where modifying/unreffing the
input stream was not protected by the lock
Comment 2 Edward Hervey 2018-06-20 08:06:38 UTC 
You could rather easily end up in situations where either the input_stream (and contained references/objects) were either double-freed or leaked.
Comment 3 Edward Hervey 2018-06-20 08:33:33 UTC 
Attachment 372733 [details] pushed as 8842d51 - souphttpsrc: Protect input stream with lock