After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 796613 - Pitch throws error 'Sample rate not defined'
Pitch throws error 'Sample rate not defined'
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.14.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-06-17 20:26 UTC by Suhas Nayak
Modified: 2018-07-18 15:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Flush single input buffer on EOS (914 bytes, patch)
2018-06-18 02:18 UTC, Suhas Nayak
none Details | Review
Do not flush if next_buffer_offset is 0 (907 bytes, patch)
2018-06-18 19:49 UTC, Suhas Nayak
none Details | Review
Do not flush if there are no unprocessed samples (909 bytes, patch)
2018-06-18 21:12 UTC, Suhas Nayak
none Details | Review
Do not flush if there are no unprocessed samples (909 bytes, patch)
2018-06-18 21:12 UTC, Suhas Nayak
none Details | Review
Flush only if there are unprocessed samples (968 bytes, patch)
2018-06-18 21:33 UTC, Suhas Nayak
committed Details | Review

Description Suhas Nayak 2018-06-17 20:26:01 UTC
SoundTouch doesn't allow flushing the buffer before sample rate is set
Comment 1 Suhas Nayak 2018-06-18 02:18:50 UTC
Created attachment 372709 [details] [review]
Flush single input buffer on EOS
Comment 2 Thibault Saunier 2018-06-18 11:25:10 UTC
Review of attachment 372709 [details] [review]:

This is a regression from https://bug796603.bugzilla-attachments.gnome.org/attachment.cgi?id=372695 which just removes that exact condition (merged yesterday :-)).

::: ext/soundtouch/gstpitch.cc
@@ -396,1 +399,1 @@
   pitch->priv->st->flush ();

Just do not flush if next_buffer_offset == 0 here, but keep the rest of the code as is.
Comment 3 Suhas Nayak 2018-06-18 19:49:33 UTC
Created attachment 372713 [details] [review]
Do not flush if next_buffer_offset is 0

The previous commit removing this condition can be reverted/this patch can be used
Comment 4 Suhas Nayak 2018-06-18 21:12:37 UTC
Created attachment 372714 [details] [review]
Do not flush if there are no unprocessed samples

next_buffer_offset is incremented only when we output the first buffer, therefore we may need to flush when next_buffer_offset is 0.
Comment 5 Suhas Nayak 2018-06-18 21:12:40 UTC
Created attachment 372715 [details] [review]
Do not flush if there are no unprocessed samples

next_buffer_offset is incremented only when we output the first buffer, therefore we may need to flush when next_buffer_offset is 0.
Comment 6 Suhas Nayak 2018-06-18 21:33:33 UTC
Created attachment 372716 [details] [review]
Flush only if there are unprocessed samples

Still try and forward the buffer
Comment 7 Mathieu Duponchelle 2018-06-18 21:39:00 UTC
Review of attachment 372716 [details] [review]:

Looks good to me, thanks!