GNOME Bugzilla – Bug 796541
waylandsink: support video crop using viewporter protocol
Last modified: 2018-11-03 14:26:15 UTC
waylandsink: support video crop using viewporter protocol use API wp_viewport_set_source() to support video crop handle
Created attachment 372605 [details] [review] waylandsink: support video crop using viewporter protocol
Can you clarify what this fixes ? I'll do the review after. I don't remember seeing this API before, did you forgot to bump the require protocol version ? Which compositors supports this ?
Ah, sorry, crop meta, that wasn't clear, can you use that term in the commit message please ?
Review of attachment 372605 [details] [review]: Ok, looks ok in general, please make a better commit message, and also update propose_allocation() as right now, if you receive a crop meta on a buffer it means up have a bug in your upstream element. Upstream element should only attach crop meta if the allocation query contains GST_VIDEO_CROP_META_API_TYPE
(In reply to Nicolas Dufresne (ndufresne) from comment #4) > Review of attachment 372605 [details] [review] [review]: > > Ok, looks ok in general, please make a better commit message, and also > update propose_allocation() as right now, if you receive a crop meta on a > buffer it means up have a bug in your upstream element. Upstream element > should only attach crop meta if the allocation query contains > GST_VIDEO_CROP_META_API_TYPE Ok, thanks. I will update this commit message and refine my code
Created attachment 372628 [details] [review] waylandsink: support video crop meta using viewporter protocol
I've tried on Weston, but it failed, saying "wl_surface@10 has viewport source outside buffer". gst-launch-1.0 videotestsrc ! videocrop top=30 ! waylandsink Any idea ?
Just looked, as caps a display width / height, we need to remember the allocation caps, or compute somehow the padded width/height, otherwise we'll get errors like this.
(In reply to Nicolas Dufresne (ndufresne) from comment #8) > Just looked, as caps a display width / height, we need to remember the > allocation caps, or compute somehow the padded width/height, otherwise we'll > get errors like this. I got some other errors like below: ** (gst-launch-1.0:3428): CRITICAL **: gst_video_frame_copy: assertion 'dinfo->width == sinfo->width && dinfo->height == sinfo->height' failed and something like below: Unsupported strides and offsets.
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/732.